From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C55EC76195 for ; Mon, 15 Jul 2019 13:55:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EDB2D20C01 for ; Mon, 15 Jul 2019 13:55:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563198924; bh=SxoPY6SDOMBvtzOk9ppQz8Q8EExZvlNfTvLTnFMYRb0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=N7gUizinBuFrNTxO2cG4H1jnmdUw86BVErmPbIPA2kprEP+TwW1rywtrj8E1/mV79 3UGigVJzpuoz9E5Quw5fCzbg//vB12Kj6vsQl1UY+5Xwy7sDNkpA1qhlUD9YG3J9VD C5pVlJVz0T6cDk2jqxR65sTWuF6vWde/E+MtWcCw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732754AbfGONzT (ORCPT ); Mon, 15 Jul 2019 09:55:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:58422 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732747AbfGONzS (ORCPT ); Mon, 15 Jul 2019 09:55:18 -0400 Received: from sasha-vm.mshome.net (unknown [73.61.17.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 11B272086C; Mon, 15 Jul 2019 13:55:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563198918; bh=SxoPY6SDOMBvtzOk9ppQz8Q8EExZvlNfTvLTnFMYRb0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pqVVGwv6mkbMX3Gv1+mY17N2LzBYEvGwObsB0H3ZNa3LkdRbSORTVNFir9kCYSDwG iifacmmNJ2l3jLc23zcyE4mGdHEMMyjfoCSbYkKPapfglD+wsh+IJFA4Q1eJxj0L7Q 326nxv80+YFY5uxcKraDGbemv86tXhwrpSAJuWg4= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Arnd Bergmann , Herbert Xu , Steffen Klassert , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.2 141/249] ipsec: select crypto ciphers for xfrm_algo Date: Mon, 15 Jul 2019 09:45:06 -0400 Message-Id: <20190715134655.4076-141-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190715134655.4076-1-sashal@kernel.org> References: <20190715134655.4076-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Arnd Bergmann [ Upstream commit 597179b0ba550bd83fab1a9d57c42a9343c58514 ] kernelci.org reports failed builds on arc because of what looks like an old missed 'select' statement: net/xfrm/xfrm_algo.o: In function `xfrm_probe_algs': xfrm_algo.c:(.text+0x1e8): undefined reference to `crypto_has_ahash' I don't see this in randconfig builds on other architectures, but it's fairly clear we want to select the hash code for it, like we do for all its other users. As Herbert points out, CRYPTO_BLKCIPHER is also required even though it has not popped up in build tests. Fixes: 17bc19702221 ("ipsec: Use skcipher and ahash when probing algorithms") Signed-off-by: Arnd Bergmann Acked-by: Herbert Xu Signed-off-by: Steffen Klassert Signed-off-by: Sasha Levin --- net/xfrm/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/xfrm/Kconfig b/net/xfrm/Kconfig index c967fc3c38c8..51bb6018f3bf 100644 --- a/net/xfrm/Kconfig +++ b/net/xfrm/Kconfig @@ -15,6 +15,8 @@ config XFRM_ALGO tristate select XFRM select CRYPTO + select CRYPTO_HASH + select CRYPTO_BLKCIPHER if INET config XFRM_USER -- 2.20.1