From: Sven Van Asbroeck <thesven73@gmail.com>
To: Fugang Duan <fugang.duan@nxp.com>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v1] net: fec: optionally reset PHY via a reset-controller
Date: Mon, 15 Jul 2019 17:05:12 -0400 [thread overview]
Message-ID: <20190715210512.15823-1-TheSven73@gmail.com> (raw)
The current fec driver allows the PHY to be reset via a gpio,
specified in the devicetree. However, some PHYs need to be reset
in a more complex way.
To accommodate such PHYs, allow an optional reset controller
in the fec devicetree. If no reset controller is found, the
fec will fall back to the legacy reset behaviour.
Example:
&fec {
phy-mode = "rgmii";
resets = <&phy_reset>;
reset-names = "phy";
status = "okay";
};
Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com>
---
Will send a Documentation patch if this receives a positive review.
drivers/net/ethernet/freescale/fec_main.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 38f10f7dcbc3..5a5f3ed6f16d 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -61,6 +61,7 @@
#include <linux/regulator/consumer.h>
#include <linux/if_vlan.h>
#include <linux/pinctrl/consumer.h>
+#include <linux/reset.h>
#include <linux/prefetch.h>
#include <soc/imx/cpuidle.h>
@@ -3335,6 +3336,7 @@ static int fec_enet_get_irq_cnt(struct platform_device *pdev)
static int
fec_probe(struct platform_device *pdev)
{
+ struct reset_control *phy_reset;
struct fec_enet_private *fep;
struct fec_platform_data *pdata;
struct net_device *ndev;
@@ -3490,7 +3492,9 @@ fec_probe(struct platform_device *pdev)
pm_runtime_set_active(&pdev->dev);
pm_runtime_enable(&pdev->dev);
- ret = fec_reset_phy(pdev);
+ phy_reset = devm_reset_control_get_exclusive(&pdev->dev, "phy");
+ ret = IS_ERR(phy_reset) ? fec_reset_phy(pdev) :
+ reset_control_reset(phy_reset);
if (ret)
goto failed_reset;
--
2.17.1
next reply other threads:[~2019-07-15 21:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 21:05 Sven Van Asbroeck [this message]
2019-07-16 2:02 ` [EXT] [PATCH v1] net: fec: optionally reset PHY via a reset-controller Andy Duan
2019-07-16 13:19 ` Sven Van Asbroeck
2019-07-17 1:32 ` Andy Duan
2019-07-17 12:48 ` Sven Van Asbroeck
2019-07-18 1:24 ` Andy Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190715210512.15823-1-TheSven73@gmail.com \
--to=thesven73@gmail.com \
--cc=davem@davemloft.net \
--cc=fugang.duan@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).