From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A23CC76186 for ; Thu, 18 Jul 2019 03:31:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B71C0205F4 for ; Thu, 18 Jul 2019 03:31:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="l4jeBLbl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389374AbfGRDbM (ORCPT ); Wed, 17 Jul 2019 23:31:12 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:49398 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387728AbfGRDbL (ORCPT ); Wed, 17 Jul 2019 23:31:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=74k0MW/dWr92M0KcbLT426aOOybqRXRrkqwfS/oc/cw=; b=l4jeBLblA5HQcCuWoJ/ocuyLD4 g7HnX6PG+jTnTSr82YrvQTJFRIXqvPcPLVRXmXeCwV5mhX8+bJSG8TMdfQgHioExg1a2rwaylrH+F c1jMIhShleX3FTBVR8k9wtZnyVCET8hPsivyxA0eZGQO0BoUQTygVSxPvCxbz365m6ws=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hnx8P-00031i-Rn; Thu, 18 Jul 2019 05:31:09 +0200 Date: Thu, 18 Jul 2019 05:31:09 +0200 From: Andrew Lunn To: Shannon Nelson Cc: netdev@vger.kernel.org Subject: Re: [PATCH v3 net-next 13/19] ionic: Add initial ethtool support Message-ID: <20190718033109.GI6962@lunn.ch> References: <20190708192532.27420-1-snelson@pensando.io> <20190708192532.27420-14-snelson@pensando.io> <20190709023050.GC5835@lunn.ch> <79f2da6f-4568-4bc8-2fa4-3aa5a41bbff1@pensando.io> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <79f2da6f-4568-4bc8-2fa4-3aa5a41bbff1@pensando.io> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Jul 12, 2019 at 10:32:38PM -0700, Shannon Nelson wrote: > On 7/8/19 7:30 PM, Andrew Lunn wrote: > >>+static int ionic_nway_reset(struct net_device *netdev) > >>+{ > >>+ struct lif *lif = netdev_priv(netdev); > >>+ int err = 0; > >>+ > >>+ if (netif_running(netdev)) > >>+ err = ionic_reset_queues(lif); > >What does ionic_reset_queues() do? It sounds nothing like restarting > >auto negotiation? > > > > Andrew > Basically, it's a rip-it-all-down-and-start-over way of restarting the > connection, and is also useful for fixing queues that are misbehaving.  It's > a little old-fashioned, taken from the ixgbe example, but is effective when > there isn't an actual "restart auto-negotiation" command in the firmware. O.K. More comments please. Did you consider throwing the firmware away and just letting Linux control the hardware? It would make this all much more transparent and debuggable. Andrew