From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 912DCC76188 for ; Mon, 22 Jul 2019 14:19:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6ABFB21911 for ; Mon, 22 Jul 2019 14:19:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="qVOsFplG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729279AbfGVOTr (ORCPT ); Mon, 22 Jul 2019 10:19:47 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:56162 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728228AbfGVOTr (ORCPT ); Mon, 22 Jul 2019 10:19:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=w7liDE+E5Iu1xIHWqacl7h46/XlirlaNe/zw3/PBWCk=; b=qVOsFplGBuYk4ymZhAgzpL6i71 /wdEDJ7Aejf42R92mP3bplohaTlECg+3Zv96yKTaZH25VSn4ERUgQoNInz2f9W2vbWPA/xWF5eOhP wUqPRaw0PMeLwHs3cj+Kw721melKrgtIO8rh8GvT5oTpSXOVQHFujFs7hLu3G+18ikIk=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hpZAF-0003Dn-Fp; Mon, 22 Jul 2019 16:19:43 +0200 Date: Mon, 22 Jul 2019 16:19:43 +0200 From: Andrew Lunn To: Jose Abreu Cc: =?utf-8?Q?Ond=C5=99ej?= Jirman , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , Joao Pinto , "David S . Miller" , Giuseppe Cavallaro , Alexandre Torgue , Russell King , Florian Fainelli , Heiner Kallweit Subject: Re: [PATCH net-next 0/3] net: stmmac: Convert to phylink Message-ID: <20190722141943.GE8972@lunn.ch> References: <20190722124240.464e73losonwb356@core.my.home> <20190722134023.GD8972@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jul 22, 2019 at 01:58:20PM +0000, Jose Abreu wrote: > From: Andrew Lunn > Date: Jul/22/2019, 14:40:23 (UTC+00:00) > > > Does this mean that all stmmac variants support 1G? There are none > > which just support Fast Ethernet? > > This glue logic drivers sometimes reflect a custom IP that's Synopsys > based but modified by customer, so I can't know before-hand what's the > supported max speed. There are some old versions that don't support 1G > but I expect that PHY driver limits this ... If a Fast PHY is used, then yes, it would be limited. But sometimes a 1G PHY is used because they are cheaper than a Fast PHY. > > I'm also not sure the change fits the problem. Why did it not > > negotiate 100FULL rather than 10Half? You are only moving the 1G > > speeds around, so 100 speeds should of been advertised and selected. > > Hmm, now that I'm looking at it closer I agree with you. Maybe link > partner or PHY doesn't support 100M ? In the working case, ethtool shows the link partner supports 10, 100, and 1G. So something odd is going on here. You fix does seems reasonable, and it has been reported to fix the issue, but it would be good to understand what is going on here. Andrew