From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 949BAC76186 for ; Wed, 24 Jul 2019 01:28:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 563B82253D for ; Wed, 24 Jul 2019 01:28:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="M0W3mvfp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728246AbfGXB2d (ORCPT ); Tue, 23 Jul 2019 21:28:33 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:55292 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727716AbfGXB2c (ORCPT ); Tue, 23 Jul 2019 21:28:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=zK0MQKBuRm5eJyPW8isSrHF1S8sYIVd055jis7yH33Y=; b=M0W3mvfpFb3UVN8RsIxzKBmjV NCtWXY23fq1PEDmA4H0cmP9ZoRf4+o675ZjXtU+C9oAAy9nS0DBxGEoOWOc7d/eyXQnOxt5Gmj19+ atCVUGGQH17T/LQuMh50lxXWAm7NdUZxNQaivoFcUzKsEc1XylbxYyhqexlanky3ebesot5xGaoMo XMlDcj4bP1MFaLD4kDoJSZ5TFeFF1+E/+ZOpc6jsC+d95IhuKo72VQeM+pvl8Q9dSQGUgXKBw0Pfi FCuURpD7UfvFappVLfd9PM48bCOKgrxvRmwkSIJhtivRGzpfLJis5JLup+wH8+KZ9kY7hPeNaxa4j rejDK9d3g==; Received: from willy by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1hq64y-0005Dx-FE; Wed, 24 Jul 2019 01:28:28 +0000 Date: Tue, 23 Jul 2019 18:28:28 -0700 From: Matthew Wilcox To: Saeed Mahameed Cc: "davem@davemloft.net" , "hch@lst.de" , "netdev@vger.kernel.org" Subject: Re: [PATCH v3 4/7] net: Reorder the contents of skb_frag_t Message-ID: <20190724012828.GQ363@bombadil.infradead.org> References: <20190712134345.19767-1-willy@infradead.org> <20190712134345.19767-5-willy@infradead.org> <2b45504e005f88a033405225b04fba0b5dcf2e92.camel@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2b45504e005f88a033405225b04fba0b5dcf2e92.camel@mellanox.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jul 23, 2019 at 10:29:06PM +0000, Saeed Mahameed wrote: > On Fri, 2019-07-12 at 06:43 -0700, Matthew Wilcox wrote: > > From: "Matthew Wilcox (Oracle)" > > > > Match the layout of bio_vec. > > > > Signed-off-by: Matthew Wilcox (Oracle) > > --- > > include/linux/skbuff.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h > > index 7910935410e6..b9dc8b4f24b1 100644 > > --- a/include/linux/skbuff.h > > +++ b/include/linux/skbuff.h > > @@ -314,8 +314,8 @@ struct skb_frag_struct { > > struct { > > struct page *p; > > } page; > > - __u32 page_offset; > > __u32 size; > > + __u32 page_offset; > > }; > > > > Why do you need this patch? this struct is going to be removed > downstream eventually .. If there's a performance regression, this is the perfect patch to include as part of the bisection. You'd think that this change could have no effect, but I've seen weirder things.