From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72468C7618B for ; Thu, 25 Jul 2019 11:39:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 45068229F9 for ; Thu, 25 Jul 2019 11:39:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MAEDyrQN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404104AbfGYLj3 (ORCPT ); Thu, 25 Jul 2019 07:39:29 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:53322 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389834AbfGYLj2 (ORCPT ); Thu, 25 Jul 2019 07:39:28 -0400 Received: by mail-wm1-f66.google.com with SMTP id x15so44685225wmj.3 for ; Thu, 25 Jul 2019 04:39:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/KNocy2+ZfOQXTjSVoKpw5gYwyEUDk8UgKcJTP4ngYE=; b=MAEDyrQNT8xSuX9iSr/7BWAuVtiFFg0r91vvdxT2++HHJS9g3J0YPwvOtkJtKUq8Jv 5iKmWqJK52t0LH1sXJk3PO+C21INeHi4V/ZYW7YuPXVIBflnQMtUHe6awRTT5dvD1DaE WpfQIVfVij+bSGThMlicGuVLRiLpF6rqQwZpgSsW3OX9UHyDapWCYIrbuJner3poxc++ G0Bn8vzCLpCMRU3GuO3rYDre/AQ/pQH9pBaRn/BU0lkFmSiIGNMktCQBPARjaQkabMe+ GuF14I1ZfrdG7ZX9sunB4JjQ9JvX8MVHFeTldfj+sF04kvwCNlmOmMZTYqLm/phbk5K8 qnTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/KNocy2+ZfOQXTjSVoKpw5gYwyEUDk8UgKcJTP4ngYE=; b=fysYU4QbSh8ojqfh6BIq2ByAM3SuSYRLUCGpnSSBkCW8rG74qAsGRIZBgorrW7S92b Uht/0FYogkB8yvSEo9trjzoQEkuVLI/5fHzAubPKJhr3CbOp7Fw+l1YrAKP4A6hyMVuu FiHQYDRxvCE9NyA4RJ4/34Ns2T5IcRHbTSqBj83JwZ1d4QXDYT1fJnR37BGBj3kXhavn pmzTDpK3jPHsTEKgCEXm3VtZB33TMTyjaVWg4IjkhXqU/lK8U7IdyFE+Hd7Oeb0Y1eW/ DTaSCInOjAMXyUKwMQCCwjiv7RtF6oCFmzQ31v8GN46k9WwEh0K2Bd7hKzyrobY+CSFh 5wlg== X-Gm-Message-State: APjAAAVST1DVTfAxcLUOibbb79wwciXvIWEQTfqu/qm92u+2lfv96BE2 EZ/62Dv6Govk5/gKAWelmilZTg== X-Google-Smtp-Source: APXvYqxKToM60L7WegP6mEG3X3RaqPtSEAUsT9RXfSRetFr+Hk/NVm3V8WF2BD26TvV4TjAbT9vnuA== X-Received: by 2002:a7b:c5c2:: with SMTP id n2mr77541522wmk.92.1564054766915; Thu, 25 Jul 2019 04:39:26 -0700 (PDT) Received: from apalos (athedsl-373703.home.otenet.gr. [79.131.11.197]) by smtp.gmail.com with ESMTPSA id p6sm53195376wrq.97.2019.07.25.04.39.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Jul 2019 04:39:26 -0700 (PDT) Date: Thu, 25 Jul 2019 14:39:22 +0300 From: Ilias Apalodimas To: Jon Hunter Cc: Jose Abreu , David Miller , "robin.murphy@arm.com" , "lists@bofh.nu" , "Joao.Pinto@synopsys.com" , "alexandre.torgue@st.com" , "maxime.ripard@bootlin.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "wens@csie.org" , "mcoquelin.stm32@gmail.com" , "linux-tegra@vger.kernel.org" , "peppe.cavallaro@st.com" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH net-next 3/3] net: stmmac: Introducing support for Page Pool Message-ID: <20190725113922.GA1703@apalos> References: <20190723.115112.1824255524103179323.davem@davemloft.net> <20190724085427.GA10736@apalos> <20190724095310.GA12991@apalos> <33de62bf-2f8a-bf00-9260-418b12bed24c@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Jon, Jose, On Thu, Jul 25, 2019 at 10:45:46AM +0100, Jon Hunter wrote: > > On 25/07/2019 08:44, Jose Abreu wrote: > > ... > > > OK. Can you please test what Ilias mentioned ? > > > > Basically you can hard-code the order to 0 in > > alloc_dma_rx_desc_resources(): > > - pp_params.order = DIV_ROUND_UP(priv->dma_buf_sz, PAGE_SIZE); > > + pp_params.order = 0; > > > > Unless you use a MTU > PAGE_SIZE. > > I made the change but unfortunately the issue persists. Yea tbh i didn't expect this to fix it, since i think the mappings are fine, but it never hurts to verify. @Jose: Can we add some debugging prints on the driver? Ideally the pages the api allocates (on init), the page that the driver is trying to use before the crash and the size of the packet (right from the device descriptor). Maybe this will tell us where the erroneous access is Thanks /Ilias