From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D344C433FF for ; Mon, 29 Jul 2019 13:13:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E15DE2070B for ; Mon, 29 Jul 2019 13:13:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P/a9JaSM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387988AbfG2NNE (ORCPT ); Mon, 29 Jul 2019 09:13:04 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:41527 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726167AbfG2NNE (ORCPT ); Mon, 29 Jul 2019 09:13:04 -0400 Received: by mail-wr1-f66.google.com with SMTP id c2so58595440wrm.8; Mon, 29 Jul 2019 06:13:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OHQOPPy7/4hwyYGA/vv5wVuORcQr6NchGp5zyU89wG0=; b=P/a9JaSMUmsNOp66pm4/R4RFIEQFC8Es01OH1gh0MDWPS/RnQH0rtCEI/iDBv1f9Ni WxEA9J/3m3OGS42vbFjgpnbNYs7Tf2K0iRZp6vaXGRyOBWZFdQIzncA6FPxHFXtzurU9 3c33csWVjCIx0g+r7ekeYxAUjueWvsm8xWlE39fvRVjHh9FNj7mZe/wb1eSmnRLLKd8b t+sQDgr4DQuNiu1Hd5NX2tcDQgA4KPTSudCRwgdJjC0F/JqHKrHejEua3r9wMQmjw148 LnEEDE7LrrWePTwwrSjlWJYDEcY14u1hAzqzrQhj2+BIiaxXIcK4MZywFSltIJNfTNGE 3J/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OHQOPPy7/4hwyYGA/vv5wVuORcQr6NchGp5zyU89wG0=; b=CGN9GuLjfEd+w6BIn5mF+tRfeypZ7v7a3rGQG6uB21XLutypFMttyucuDhotUjDhCR 77NqgMTtxrjww/w3kDdHI+utB5E1p3Y0Zyu+8vhm5izsF8ySWg96AjP9pHZ3Kyk07HXm 9AuqwhATjTeL7Ym1dlC7DzVdDUazMtVyyy4rFArcLK7sPYDNIOt9iMvLs1pLKuvbkR+T XaNnGio8sBZVl+igYk7s+NB2pRdAYoHgxOmU39TY5Ve34PQhJDfuxt6VSlOGtmImTeGN q3JJSwCg3xoKKmYLOy95GiQVv8oVeaIlb32dszSD9sRFqjXvnPHWzxKjYPJvBGGV2Gsn +wCA== X-Gm-Message-State: APjAAAWPYY/wXavmzoWYBcEQJhuDF2pO8gdUrXq/VJs0VcClbto5JhmO A0Hshp9IbJO0pX/7uSYyEMnGYzAIbWdrhA== X-Google-Smtp-Source: APXvYqzvfTuzes+bHEgolmvEBkRLWuJKdlVEp7pcE1/Xi2hdZ9+35M+JXXfDbjbWyLqFKoVnUFEvOQ== X-Received: by 2002:adf:efc8:: with SMTP id i8mr64680709wrp.220.1564405981926; Mon, 29 Jul 2019 06:13:01 -0700 (PDT) Received: from localhost ([51.15.41.238]) by smtp.gmail.com with ESMTPSA id i18sm81642557wrp.91.2019.07.29.06.13.00 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 29 Jul 2019 06:13:00 -0700 (PDT) Date: Mon, 29 Jul 2019 14:12:59 +0100 From: Stefan Hajnoczi To: Stefano Garzarella Cc: Stefan Hajnoczi , kvm@vger.kernel.org, "Michael S. Tsirkin" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, "David S. Miller" Subject: Re: [PATCH v4 0/5] vsock/virtio: optimizations to increase the throughput Message-ID: <20190729131259.GA6771@stefanha-x1.localdomain> References: <20190717113030.163499-1-sgarzare@redhat.com> <20190722090835.GF24934@stefanha-x1.localdomain> <20190722091434.tzf7lxw3tvrs5w5v@steredhat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tKW2IUtsqtDRztdT" Content-Disposition: inline In-Reply-To: <20190722091434.tzf7lxw3tvrs5w5v@steredhat> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --tKW2IUtsqtDRztdT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 22, 2019 at 11:14:34AM +0200, Stefano Garzarella wrote: > On Mon, Jul 22, 2019 at 10:08:35AM +0100, Stefan Hajnoczi wrote: > > On Wed, Jul 17, 2019 at 01:30:25PM +0200, Stefano Garzarella wrote: > > > This series tries to increase the throughput of virtio-vsock with sli= ght > > > changes. > > > While I was testing the v2 of this series I discovered an huge use of= memory, > > > so I added patch 1 to mitigate this issue. I put it in this series in= order > > > to better track the performance trends. > > >=20 > > > v4: > > > - rebased all patches on current master (conflicts is Patch 4) > > > - Patch 1: added Stefan's R-b > > > - Patch 3: removed lock when buf_alloc is written [David]; > > > moved this patch after "vsock/virtio: reduce credit update= messages" > > > to make it clearer > > > - Patch 4: vhost_exceeds_weight() is recently introduced, so I've sol= ved some > > > conflicts > >=20 > > Stefano: Do you want to continue experimenting before we merge this > > patch series? The code looks functionally correct and the performance > > increases, so I'm happy for it to be merged. >=20 > I think we can merge this series. >=20 > I'll continue to do other experiments (e.g. removing TX workers, allocati= ng > pages, etc.) but I think these changes are prerequisites for the other pa= tches, > so we can merge them. >=20 > Thank you very much for the reviews! All patches have been reviewed by here. Have an Ack for good measure: Acked-by: Stefan Hajnoczi The topics discussed in sub-threads relate to longer-term optimization work that doesn't block this series. Please merge. --tKW2IUtsqtDRztdT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAl0+8NsACgkQnKSrs4Gr c8gLNgf/Y63sHjZ3yrw3pup1KDkZmcZX9U+gUxzFkEnpGo8Uz20pFa0UQ8EgfdIP Ow+qZ9hm77WDbeAx8lyWTwAV1C2WS1k5RMpqWJzBdI45MixObQ2+2/ddp+igHDAJ L7pDH+Wwc/7p0FcMuUqqQKl6MM2yJ9zHrRu/5xVtrWNuw4Hdt7BvWshvE0G496kv 0itr7U5WqDstqYPBWm1DbGBr6Nnwv7a3R/3lslRsTiN3em63/Gl+hVgb+jvk/wSl W8BS+9/UJkaBG0vv+f89e7xqqvCP90S8CPGtk3LhUhufdf+5I/Hekm+eY7MDN+Au xX2HJr/ZEPFdghVj8F+OODK+aDR6aw== =tIn+ -----END PGP SIGNATURE----- --tKW2IUtsqtDRztdT--