From: Matthew Wilcox <willy@infradead.org>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: David Miller <davem@davemloft.net>,
andrew@lunn.ch, broonie@kernel.org, devel@driverdev.osuosl.org,
f.fainelli@gmail.com, gregkh@linuxfoundation.org,
hkallweit1@gmail.com, kernel-build-reports@lists.linaro.org,
linux-arm-kernel@lists.infradead.org, linux-next@vger.kernel.org,
netdev@vger.kernel.org, lkp@intel.com, rdunlap@infradead.org
Subject: Re: [PATCH] net: mdio-octeon: Fix build error and Kconfig warning
Date: Fri, 2 Aug 2019 18:39:52 -0700 [thread overview]
Message-ID: <20190803013952.GF5597@bombadil.infradead.org> (raw)
In-Reply-To: <20190803013031.GA76252@archlinux-threadripper>
On Fri, Aug 02, 2019 at 06:30:31PM -0700, Nathan Chancellor wrote:
> On Fri, Aug 02, 2019 at 06:11:32PM -0700, David Miller wrote:
> > The proper way to fix this is to include either
> >
> > linux/io-64-nonatomic-hi-lo.h
> >
> > or
> >
> > linux/io-64-nonatomic-lo-hi.h
> >
> > whichever is appropriate.
>
> Hmmmm, is that not what I did?
>
> Although I did not know about io-64-nonatomic-hi-lo.h. What is the
> difference and which one is needed here?
Whether you write the high or low 32 bits first. For this, it doesn't
matter, since the compiled driver will never be run on real hardware.
> There is apparently another failure when OF_MDIO is not set, I guess I
> can try to look into that as well and respin into a series if
> necessary.
Thanks for taking care of that!
next prev parent reply other threads:[~2019-08-03 1:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5d41767d.1c69fb81.d6304.4c8c@mx.google.com>
2019-07-31 11:24 ` next/master build: 221 builds: 11 failed, 210 passed, 13 errors, 1174 warnings (next-20190731) Mark Brown
2019-07-31 11:35 ` Greg Kroah-Hartman
2019-07-31 15:48 ` David Miller
2019-07-31 16:00 ` Greg KH
2019-07-31 16:35 ` Nathan Chancellor
2019-07-31 16:41 ` David Miller
2019-07-31 18:50 ` [PATCH] net: mdio-octeon: Fix build error and Kconfig warning Nathan Chancellor
2019-07-31 21:55 ` Randy Dunlap
2019-07-31 23:52 ` Randy Dunlap
2019-09-19 9:06 ` Geert Uytterhoeven
2019-08-03 1:11 ` David Miller
2019-08-03 1:30 ` Nathan Chancellor
2019-08-03 1:39 ` Matthew Wilcox [this message]
2019-08-03 6:05 ` Nathan Chancellor
2019-08-03 6:01 ` [PATCH v2] net: mdio-octeon: Fix Kconfig warnings and build errors Nathan Chancellor
2019-08-03 18:34 ` Randy Dunlap
2019-08-06 21:11 ` David Miller
2019-08-07 5:10 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190803013952.GF5597@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=kernel-build-reports@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-next@vger.kernel.org \
--cc=lkp@intel.com \
--cc=natechancellor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).