From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Jacob Keller <jacob.e.keller@intel.com>,
netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
Andrew Bowers <andrewx.bowers@intel.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 4/8] fm10k: explicitly return 0 on success path in function
Date: Sun, 4 Aug 2019 04:59:22 -0700 [thread overview]
Message-ID: <20190804115926.31944-5-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <20190804115926.31944-1-jeffrey.t.kirsher@intel.com>
From: Jacob Keller <jacob.e.keller@intel.com>
In the fm10k_handle_resume function, return 0 explicitly at the end of
the function instead of returning the err value.
This was detected by cppcheck and resolves the following style warning
produced by that tool:
[fm10k_pci.c:2768] -> [fm10k_pci.c:2787]: (warning) Identical condition
'err', second condition is always false
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
index 9522e9f8f8b8..73928dbe714f 100644
--- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
@@ -2340,7 +2340,7 @@ static int fm10k_handle_resume(struct fm10k_intfc *interface)
/* Restart the MAC/VLAN request queue in-case of outstanding events */
fm10k_macvlan_schedule(interface);
- return err;
+ return 0;
}
/**
--
2.21.0
next prev parent reply other threads:[~2019-08-04 11:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-04 11:59 [net-next 0/8][pull request] 100GbE Intel Wired LAN Driver Updates 2019-08-04 Jeff Kirsher
2019-08-04 11:59 ` [net-next 1/8] fm10k: remove unnecessary variable initializer Jeff Kirsher
2019-08-04 11:59 ` [net-next 2/8] fm10k: remove needless assignment of err local variable Jeff Kirsher
2019-08-04 11:59 ` [net-next 3/8] fm10k: remove needless initialization of size " Jeff Kirsher
2019-08-04 11:59 ` Jeff Kirsher [this message]
2019-08-04 11:59 ` [net-next 5/8] fm10k: cast page_addr to u8 * when incrementing it Jeff Kirsher
2019-08-04 11:59 ` [net-next 6/8] fm10k: mark unused parameters with __always_unused Jeff Kirsher
2019-08-04 11:59 ` [net-next 7/8] fm10k: convert NON_Q_VECTORS(hw) into NON_Q_VECTORS Jeff Kirsher
2019-08-04 11:59 ` [net-next 8/8] fm10k: fix fm10k_get_fault_pf to read correct address Jeff Kirsher
2019-08-06 3:17 ` [net-next 0/8][pull request] 100GbE Intel Wired LAN Driver Updates 2019-08-04 Jakub Kicinski
2019-08-06 21:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190804115926.31944-5-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=andrewx.bowers@intel.com \
--cc=davem@davemloft.net \
--cc=jacob.e.keller@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).