netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yangbo Lu <yangbo.lu@nxp.com>
To: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>
Cc: Yangbo Lu <yangbo.lu@nxp.com>
Subject: [PATCH 3/3] ocelot_ace: fix action of trap
Date: Mon, 12 Aug 2019 18:48:27 +0800	[thread overview]
Message-ID: <20190812104827.5935-4-yangbo.lu@nxp.com> (raw)
In-Reply-To: <20190812104827.5935-1-yangbo.lu@nxp.com>

The trap action should be copying the frame to CPU and
dropping it for forwarding, but current setting was just
copying frame to CPU.

Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
---
 drivers/net/ethernet/mscc/ocelot_ace.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/mscc/ocelot_ace.c b/drivers/net/ethernet/mscc/ocelot_ace.c
index 91250f3..59ad590 100644
--- a/drivers/net/ethernet/mscc/ocelot_ace.c
+++ b/drivers/net/ethernet/mscc/ocelot_ace.c
@@ -317,9 +317,9 @@ static void is2_action_set(struct vcap_data *data,
 		break;
 	case OCELOT_ACL_ACTION_TRAP:
 		VCAP_ACT_SET(PORT_MASK, 0x0);
-		VCAP_ACT_SET(MASK_MODE, 0x0);
-		VCAP_ACT_SET(POLICE_ENA, 0x0);
-		VCAP_ACT_SET(POLICE_IDX, 0x0);
+		VCAP_ACT_SET(MASK_MODE, 0x1);
+		VCAP_ACT_SET(POLICE_ENA, 0x1);
+		VCAP_ACT_SET(POLICE_IDX, OCELOT_POLICER_DISCARD);
 		VCAP_ACT_SET(CPU_QU_NUM, 0x0);
 		VCAP_ACT_SET(CPU_COPY_ENA, 0x1);
 		break;
-- 
2.7.4


  parent reply	other threads:[~2019-08-12 10:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-12 10:48 [PATCH 0/3] ocelot_ace: fix and improve the driver Yangbo Lu
2019-08-12 10:48 ` [PATCH 1/3] ocelot_ace: drop member port from ocelot_ace_rule structure Yangbo Lu
2019-08-12 10:48 ` [PATCH 2/3] ocelot_ace: fix ingress ports setting for rule Yangbo Lu
2019-08-12 12:38   ` Allan W. Nielsen
2019-08-13  2:36     ` Y.b. Lu
2019-08-12 10:48 ` Yangbo Lu [this message]
2019-08-12 12:31   ` [PATCH 3/3] ocelot_ace: fix action of trap Allan W. Nielsen
2019-08-13  2:12     ` Y.b. Lu
2019-08-13  6:16       ` Allan W. Nielsen
2019-08-14  4:03         ` Y.b. Lu
2019-08-14  6:45           ` Allan W. Nielsen
2019-08-13 13:42       ` Andrew Lunn
2019-08-14  4:28         ` Y.b. Lu
2019-08-14  8:57           ` Allan W. Nielsen
2019-08-14 13:52             ` Andrew Lunn
2019-08-15 12:39               ` Y.b. Lu
2019-08-14 13:42           ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190812104827.5935-4-yangbo.lu@nxp.com \
    --to=yangbo.lu@nxp.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).