From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16C4FC433FF for ; Tue, 13 Aug 2019 09:55:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E6D8B20663 for ; Tue, 13 Aug 2019 09:55:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728513AbfHMJzf (ORCPT ); Tue, 13 Aug 2019 05:55:35 -0400 Received: from correo.us.es ([193.147.175.20]:34454 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728322AbfHMJzf (ORCPT ); Tue, 13 Aug 2019 05:55:35 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id DA4EBFC5E0 for ; Tue, 13 Aug 2019 11:55:32 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id CAEC8DA7B9 for ; Tue, 13 Aug 2019 11:55:32 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id C08EEDA730; Tue, 13 Aug 2019 11:55:32 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id C1C29D190F; Tue, 13 Aug 2019 11:55:30 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Tue, 13 Aug 2019 11:55:30 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [31.4.218.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 95C3D4265A2F; Tue, 13 Aug 2019 11:55:30 +0200 (CEST) Date: Tue, 13 Aug 2019 11:55:29 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Jeremy Sowden Cc: Netfilter Devel , Net Dev , Masahiro Yamada Subject: Re: [PATCH net-next v1 0/8] netfilter: header compilation fixes Message-ID: <20190813095529.aisgjjwl6rzt5xeh@salvia> References: <20190722201615.GE23346@azazel.net> <20190807141705.4864-1-jeremy@azazel.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190807141705.4864-1-jeremy@azazel.net> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Aug 07, 2019 at 03:16:57PM +0100, Jeremy Sowden wrote: > A number of netfilter header files are on the header-test blacklist > becuse they cannot be compiled stand-alone. There are two main reasons > for this: missing inclusions of other headers, and missing conditionals > checking for CONFIG_* symbols. > > The first six of these patches rectify these omissions, the seventh > removes some unnecessary "#ifdef __KERNEL__" checks, and the last > removes all the NF headers from the blacklist. > > I've cc'ed Masahiro Yamada because the last patch removes 74 lines from > include/Kbuild and may conflict with his kbuild tree. Series applied, one comment below. > Jeremy Sowden (8): > netfilter: inlined four headers files into another one. > netfilter: added missing includes to a number of header-files. > netfilter: added missing IS_ENABLED(CONFIG_BRIDGE_NETFILTER) checks to > header-file. > netfilter: added missing IS_ENABLED(CONFIG_NF_TABLES) check to > header-file. > netfilter: added missing IS_ENABLED(CONFIG_NF_CONNTRACK) checks to > some header-files. > netfilter: added missing IS_ENABLED(CONFIG_NETFILTER) checks to some > header-files. > netfilter: removed "#ifdef __KERNEL__" guards from some headers. > kbuild: removed all netfilter headers from header-test blacklist. Would you mind if - before pushing this out - I do this string replacement for the patch subject? s/added/add s/removed/remove s/inlined/inline I was told present tense is preferred for description. Otherwise, I'll leave them as is. Thanks.