From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Thomas Falcon <tlfalcon@linux.ibm.com>
Cc: netdev@vger.kernel.org, liuhangbin@gmail.com,
davem@davemloft.net, joe@perches.com
Subject: Re: [PATCH net v2] ibmveth: Convert multicast list size for little-endian system
Date: Tue, 13 Aug 2019 19:43:47 -0700 [thread overview]
Message-ID: <20190813194037.464bea2c@cakuba.netronome.com> (raw)
In-Reply-To: <1565644386-22284-1-git-send-email-tlfalcon@linux.ibm.com>
On Mon, 12 Aug 2019 16:13:06 -0500, Thomas Falcon wrote:
> The ibm,mac-address-filters property defines the maximum number of
> addresses the hypervisor's multicast filter list can support. It is
> encoded as a big-endian integer in the OF device tree, but the virtual
> ethernet driver does not convert it for use by little-endian systems.
> As a result, the driver is not behaving as it should on affected systems
> when a large number of multicast addresses are assigned to the device.
>
> Reported-by: Hangbin Liu <liuhangbin@gmail.com>
> Signed-off-by: Thomas Falcon <tlfalcon@linux.ibm.com>
Okay, applied, but:
> diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c
> index 77af9c2c0571..5641c00d34f2 100644
> --- a/drivers/net/ethernet/ibm/ibmveth.c
> +++ b/drivers/net/ethernet/ibm/ibmveth.c
> @@ -1643,7 +1643,7 @@ static int ibmveth_probe(struct vio_dev *dev, const struct vio_device_id *id)
> struct net_device *netdev;
> struct ibmveth_adapter *adapter;
> unsigned char *mac_addr_p;
> - unsigned int *mcastFilterSize_p;
> + __be32 *mcastFilterSize_p;
> long ret;
> unsigned long ret_attr;
>
> @@ -1665,8 +1665,9 @@ static int ibmveth_probe(struct vio_dev *dev, const struct vio_device_id *id)
> return -EINVAL;
> }
>
> - mcastFilterSize_p = (unsigned int *)vio_get_attribute(dev,
> - VETH_MCAST_FILTER_SIZE, NULL);
> + mcastFilterSize_p = (__be32 *)vio_get_attribute(dev,
> + VETH_MCAST_FILTER_SIZE,
> + NULL);
> if (!mcastFilterSize_p) {
> dev_err(&dev->dev, "Can't find VETH_MCAST_FILTER_SIZE "
> "attribute\n");
> @@ -1683,7 +1684,7 @@ static int ibmveth_probe(struct vio_dev *dev, const struct vio_device_id *id)
>
> adapter->vdev = dev;
> adapter->netdev = netdev;
> - adapter->mcastFilterSize = *mcastFilterSize_p;
> + adapter->mcastFilterSize = be32_to_cpu(*mcastFilterSize_p);
> adapter->pool_config = 0;
> ibmveth_init_link_settings(adapter);
ibmveth_init_link_settings() is part of your net-next patch which
you're respining, so I had to apply manually. Please double check your
patches apply cleanly to the designated tree.
next prev parent reply other threads:[~2019-08-14 2:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 21:13 [PATCH net v2] ibmveth: Convert multicast list size for little-endian system Thomas Falcon
2019-08-14 2:43 ` Jakub Kicinski [this message]
2019-08-14 15:41 ` Thomas Falcon
2019-08-14 3:35 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190813194037.464bea2c@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=tlfalcon@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).