From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94432C3A59C for ; Fri, 16 Aug 2019 12:21:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B22A2064A for ; Fri, 16 Aug 2019 12:21:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565958067; bh=c5voliBFvGt2qugCHsr8cX6oIZuqbKkcCDgNMCAlo14=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=gAqhDP+mMA6dnbi9vjRY/+njApKaU7HiQjJKtB3urJqFNpAHFNMPBYS0mpy8P/+Rz gyLoKN1WA8WcjASr+TAfmrVVj2qUjJNpAwwopNyXZQsl2iwXWXn29bb3aHeDz/DqhP J8Tb4vagxUjMpNzSaB674vj53u1ikA9bnj6cNOpg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727224AbfHPMVG (ORCPT ); Fri, 16 Aug 2019 08:21:06 -0400 Received: from mail-ed1-f100.google.com ([209.85.208.100]:34988 "EHLO mail-ed1-f100.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727206AbfHPMVF (ORCPT ); Fri, 16 Aug 2019 08:21:05 -0400 Received: by mail-ed1-f100.google.com with SMTP id w20so4969476edd.2 for ; Fri, 16 Aug 2019 05:21:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=tKhOd3WCCS81mToTkVuzJS8ppaBmXDvx6Wnxxnym8UA=; b=lT8WWspfpJAHQsDqJ0HoGGiHV8h9+dDLRdb9lvbc4M+2Gna04bFktvOaeqEQq9AD9t tJUI7yJG8cgQzRuUSvf6NOJTuYlDh6B0zRnRJ248HNHy3tPzfUWNB4CeYXQQvFiQwGU4 EN5tm3eZTOYbSN90uddDjfRHuA+CjddxQmGLgu0V9rE4eUWWygh9yCoNu2dKIaGe3FBL d0QYmUr15tY93js1pQzZxYd0EmBS5/z6uoo0NX1V7MVOvq3L1t3E9ifbC4L//PufH7md JV+5Miy94USMyPjhgTZcIH5nun1hiLWnCcP40oI12xkKhr3VVco47dLr/257TEzwTsOZ N+Ag== X-Gm-Message-State: APjAAAVdfuMTBTi2Zi2KJENq/kftbkhDmWGbwGmMGXCN820Mvc8cD205 H2bVLIXVCWd6AAYP9j6DUd4XD0h1JMcuui8BuEac3kphzunrWzYrBSt5Zdv0FlAfvQ== X-Google-Smtp-Source: APXvYqyFDPVRuRVwUVQN1kIePjFpx4dlJQLiWIWPHH9631C2TJn6okaPRQ51znHz4j/5JNjE11Aw/HA9rtFA X-Received: by 2002:a17:906:1303:: with SMTP id w3mr9048193ejb.143.1565958064263; Fri, 16 Aug 2019 05:21:04 -0700 (PDT) Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk. [2a01:7e01::f03c:91ff:fed4:a3b6]) by smtp-relay.gmail.com with ESMTPS id o23sm21973eja.23.2019.08.16.05.21.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Aug 2019 05:21:04 -0700 (PDT) X-Relaying-Domain: sirena.org.uk Received: from ypsilon.sirena.org.uk ([2001:470:1f1d:6b5::7]) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hybE7-0003R1-Un; Fri, 16 Aug 2019 12:21:04 +0000 Received: by ypsilon.sirena.org.uk (Postfix, from userid 1000) id 2D12127430D6; Fri, 16 Aug 2019 13:21:03 +0100 (BST) Date: Fri, 16 Aug 2019 13:21:03 +0100 From: Mark Brown To: Vladimir Oltean Cc: h.feurstein@gmail.com, mlichvar@redhat.com, richardcochran@gmail.com, andrew@lunn.ch, f.fainelli@gmail.com, linux-spi@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [RFC PATCH net-next 04/11] spi: spi-fsl-dspi: Cosmetic cleanup Message-ID: <20190816122103.GE4039@sirena.co.uk> References: <20190816004449.10100-1-olteanv@gmail.com> <20190816004449.10100-5-olteanv@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Q8BnQc91gJZX4vDc" Content-Disposition: inline In-Reply-To: <20190816004449.10100-5-olteanv@gmail.com> X-Cookie: My life is a patio of fun! User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --Q8BnQc91gJZX4vDc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Aug 16, 2019 at 03:44:42AM +0300, Vladimir Oltean wrote: > This patch addresses some cosmetic issues: > - Alignment > - Typos > - (Non-)use of BIT() and GENMASK() macros > - Unused definitions > - Unused includes > - Abuse of ternary operator in detriment of readability > - Reduce indentation level This is difficult to review since there's a bunch of largely unrelated changes all munged into one patch. It'd be better to split this up so each change makes one kind of fix, and better to do this separately to the rest of the series. In particular having alignment changes along with other changes hurts reviewability as it's less immediately clear what's a like for liken substitution. --Q8BnQc91gJZX4vDc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl1Wn64ACgkQJNaLcl1U h9D5Bwf+OKuQMiT2y6NsdVvC4VV6RHVuXDYQxs3lIWdb2gLw+ikQZum3e77gvc+Z If4Yc1d+XAwqFbrD81a522yH0cyGfWIed/Hlmc6CwkKMZC1j+0ngO2PSIKeBdZzA cuVlqNjke4qPs6lsNcBN9tig3A7Qer4de9hkCCtctdPGBalJSBprV+ow85cjyXbp 4wvnTojb1EzWCMplDPvoTeAGgZHZjsfp5lpf+eTI+isYBjRFeyokFvsosUZiMdZI Wi+o/Swe1nL/6jM8+EVmJpUzTUDtT191cSM4KaHEifU9zXdrSk1ss09wlruRAETy ACNvbL2isq76eFbeLwIwtDqf/mfaaA== =2xml -----END PGP SIGNATURE----- --Q8BnQc91gJZX4vDc--