From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, marcelo.leitner@gmail.com,
jiri@resnulli.us, wenxu@ucloud.cn, saeedm@mellanox.com,
paulb@mellanox.com, gerlitz.or@gmail.com
Subject: Re: [PATCH net,v5 2/2] netfilter: nf_tables: map basechain priority to hardware priority
Date: Fri, 16 Aug 2019 12:44:39 -0700 [thread overview]
Message-ID: <20190816124439.7cc166c1@cakuba.netronome.com> (raw)
In-Reply-To: <20190816012410.31844-3-pablo@netfilter.org>
On Fri, 16 Aug 2019 03:24:10 +0200, Pablo Neira Ayuso wrote:
> This patch adds initial support for offloading basechains using the
> priority range from 1 to 65535. This is restricting the netfilter
> priority range to 16-bit integer since this is what most drivers assume
> so far from tc. It should be possible to extend this range of supported
> priorities later on once drivers are updated to support for 32-bit
> integer priorities.
>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> ---
> v5: fix clang warning by simplifying the mapping of hardware priorities
> to basechain priority in the range of 1-65535. Zero is left behind
> since some drivers do not support this, no negative basechain
> priorities are used at this stage.
LGTM.
next prev parent reply other threads:[~2019-08-16 19:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 1:24 [PATCH net,v5 0/2] flow_offload hardware priority fixes Pablo Neira Ayuso
2019-08-16 1:24 ` [PATCH net,v5 1/2] net: sched: use major priority number as hardware priority Pablo Neira Ayuso
2019-08-16 1:24 ` [PATCH net,v5 2/2] netfilter: nf_tables: map basechain priority to " Pablo Neira Ayuso
2019-08-16 19:44 ` Jakub Kicinski [this message]
2019-08-18 21:13 ` [PATCH net,v5 0/2] flow_offload hardware priority fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190816124439.7cc166c1@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=davem@davemloft.net \
--cc=gerlitz.or@gmail.com \
--cc=jiri@resnulli.us \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=paulb@mellanox.com \
--cc=saeedm@mellanox.com \
--cc=wenxu@ucloud.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).