From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 876DFC3A59E for ; Fri, 16 Aug 2019 12:10:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 69B692086C for ; Fri, 16 Aug 2019 12:10:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727137AbfHPMKQ (ORCPT ); Fri, 16 Aug 2019 08:10:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56322 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727104AbfHPMKQ (ORCPT ); Fri, 16 Aug 2019 08:10:16 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1964825CCB; Fri, 16 Aug 2019 12:10:16 +0000 (UTC) Received: from carbon (ovpn-200-29.brq.redhat.com [10.40.200.29]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6DA721001B28; Fri, 16 Aug 2019 12:10:03 +0000 (UTC) Date: Fri, 16 Aug 2019 14:10:01 +0200 From: Jesper Dangaard Brouer To: Andrii Nakryiko Cc: brouer@redhat.com, , , , , Michael Holzheu , "Naveen N . Rao" , "David S . Miller" , Michal Rostecki , John Fastabend , Sargun Dhillon Subject: Re: [PATCH bpf-next] libbpf: relicense bpf_helpers.h and bpf_endian.h Message-ID: <20190816141001.4a879101@carbon> In-Reply-To: <20190816054543.2215626-1-andriin@fb.com> References: <20190816054543.2215626-1-andriin@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 16 Aug 2019 12:10:16 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 15 Aug 2019 22:45:43 -0700 Andrii Nakryiko wrote: > bpf_helpers.h and bpf_endian.h contain useful macros and BPF helper > definitions essential to almost every BPF program. Which makes them > useful not just for selftests. To be able to expose them as part of > libbpf, though, we need them to be dual-licensed as LGPL-2.1 OR > BSD-2-Clause. This patch updates licensing of those two files. I've already ACKed this, and is fine with (LGPL-2.1 OR BSD-2-Clause). I just want to understand, why "BSD-2-Clause" and not "Apache-2.0" ? The original argument was that this needed to be compatible with "Apache-2.0", then why not simply add this in the "OR" ? > Acked-by: Alexei Starovoitov > Acked-by: Hechao Li > Acked-by: Martin KaFai Lau > Acked-by: Andrey Ignatov > Acked-by: Yonghong Song > Acked-by: Lawrence Brakmo > Acked-by: Adam Barth > Acked-by: Roman Gushchin > Acked-by: Josef Bacik > Acked-by: Joe Stringer > Acked-by: Daniel Borkmann > Acked-by: Joel Fernandes (Google) > Acked-by: David Ahern > Acked-by: Jesper Dangaard Brouer Confirming I acked this. > Acked-by: Ilya Leoshkevich > Acked-by: Lorenz Bauer > Acked-by: Adrian Ratiu > Acked-by: Nikita V. Shirokov > Acked-by: Willem de Bruijn > Acked-by: Petar Penkov > Acked-by: Teng Qin > Cc: Michael Holzheu > Cc: Naveen N. Rao > Cc: David S. Miller > Cc: Michal Rostecki > Cc: John Fastabend > Cc: Sargun Dhillon > Signed-off-by: Andrii Nakryiko > --- > tools/testing/selftests/bpf/bpf_endian.h | 2 +- > tools/testing/selftests/bpf/bpf_helpers.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/bpf/bpf_endian.h b/tools/testing/selftests/bpf/bpf_endian.h > index 05f036df8a4c..ff3593b0ae03 100644 > --- a/tools/testing/selftests/bpf/bpf_endian.h > +++ b/tools/testing/selftests/bpf/bpf_endian.h > @@ -1,4 +1,4 @@ > -/* SPDX-License-Identifier: GPL-2.0 */ > +/* SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) */ > #ifndef __BPF_ENDIAN__ > #define __BPF_ENDIAN__ > > diff --git a/tools/testing/selftests/bpf/bpf_helpers.h b/tools/testing/selftests/bpf/bpf_helpers.h > index 8b503ea142f0..6c4930bc6e2e 100644 > --- a/tools/testing/selftests/bpf/bpf_helpers.h > +++ b/tools/testing/selftests/bpf/bpf_helpers.h > @@ -1,4 +1,4 @@ > -/* SPDX-License-Identifier: GPL-2.0 */ > +/* SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) */ > #ifndef __BPF_HELPERS_H > #define __BPF_HELPERS_H > -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer