From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=8vnC=WM=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 6DC19C3A59C
	for <netdev@archiver.kernel.org>; Fri, 16 Aug 2019 17:05:24 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 372222077C
	for <netdev@archiver.kernel.org>; Fri, 16 Aug 2019 17:05:24 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=pass (1024-bit key) header.d=nic.cz header.i=@nic.cz header.b="LjjpsjqM"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727561AbfHPRFX (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Fri, 16 Aug 2019 13:05:23 -0400
Received: from mail.nic.cz ([217.31.204.67]:33740 "EHLO mail.nic.cz"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726447AbfHPRFW (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 16 Aug 2019 13:05:22 -0400
Received: from localhost (unknown [172.20.6.135])
        by mail.nic.cz (Postfix) with ESMTPSA id 394B9140CDF;
        Fri, 16 Aug 2019 19:05:21 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default;
        t=1565975121; bh=x8L86W80XXo3KBte8Ib77YU49u6r2jeJ7zT2GiMxzlE=;
        h=Date:From:To;
        b=LjjpsjqMwAmnEG3qD6ftr5Di8Fwn29BhCn1shkVqfIu1iDTe1HSRLOwiI+vb+oxJa
         fHQMNad2yX9IrnHawUnIfYwDPS/ataHMR9C2TRUYf0nssKCjerTwWKy05CSwpUDdNI
         B73a7v3xIU3tnVhAMnE+PI97w456HtQgwVsXV/mY=
Date:   Fri, 16 Aug 2019 19:05:20 +0200
From:   Marek Behun <marek.behun@nic.cz>
To:     Vivien Didelot <vivien.didelot@gmail.com>
Cc:     netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
        Vladimir Oltean <olteanv@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH RFC net-next 3/3] net: dsa: mv88e6xxx: setup SERDES irq
 also for CPU/DSA ports
Message-ID: <20190816190520.57958fde@nic.cz>
In-Reply-To: <20190816122552.GC629@t480s.localdomain>
References: <20190816150834.26939-1-marek.behun@nic.cz>
        <20190816150834.26939-4-marek.behun@nic.cz>
        <20190816122552.GC629@t480s.localdomain>
X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: clamav-milter 0.100.3 at mail.nic.cz
X-Virus-Status: Clean
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Fri, 16 Aug 2019 12:25:52 -0400
Vivien Didelot <vivien.didelot@gmail.com> wrote:

> So now we have mv88e6xxx_setup_port() and mv88e6xxx_port_setup(), which both
> setup a port, differently, at different time. This is definitely error prone.

Hmm. I don't know how much of mv88e6xxx_setup_port() could be moved to
this new port_setup(), since there are other setup functions called in
mv88e6xxx_setup() that can possibly depend on what was done by
mv88e6xxx_setup_port().

Maybe the new DSA operations should be called .after_setup()
and .before_teardown(), and be called just once for the whole switch,
not for each port?