From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andriin@fb.com>,
bpf@vger.kernel.org, netdev@vger.kernel.org,
andrii.nakryiko@gmail.com, kernel-team@fb.com,
Michael Holzheu <holzheu@linux.vnet.ibm.com>,
"Naveen N . Rao" <naveen.n.rao@linux.vnet.ibm.com>,
"David S . Miller" <davem@davemloft.net>,
Michal Rostecki <mrostecki@opensuse.org>,
John Fastabend <john.fastabend@gmail.com>,
Sargun Dhillon <sargun@sargun.me>,
brouer@redhat.com
Subject: Re: [PATCH bpf-next] libbpf: relicense bpf_helpers.h and bpf_endian.h
Date: Fri, 16 Aug 2019 22:10:25 +0200 [thread overview]
Message-ID: <20190816221025.239e9e94@carbon> (raw)
In-Reply-To: <20190816171529.GA20099@kroah.com>
On Fri, 16 Aug 2019 19:15:29 +0200
Greg KH <gregkh@linuxfoundation.org> wrote:
> On Fri, Aug 16, 2019 at 05:29:27PM +0200, Daniel Borkmann wrote:
> > On 8/16/19 2:10 PM, Jesper Dangaard Brouer wrote:
> > > On Thu, 15 Aug 2019 22:45:43 -0700
> > > Andrii Nakryiko <andriin@fb.com> wrote:
> > >
> > > > bpf_helpers.h and bpf_endian.h contain useful macros and BPF helper
> > > > definitions essential to almost every BPF program. Which makes them
> > > > useful not just for selftests. To be able to expose them as part of
> > > > libbpf, though, we need them to be dual-licensed as LGPL-2.1 OR
> > > > BSD-2-Clause. This patch updates licensing of those two files.
> > >
> > > I've already ACKed this, and is fine with (LGPL-2.1 OR BSD-2-Clause).
> > >
> > > I just want to understand, why "BSD-2-Clause" and not "Apache-2.0" ?
> > >
> > > The original argument was that this needed to be compatible with
> > > "Apache-2.0", then why not simply add this in the "OR" ?
> >
> > It's use is discouraged in the kernel tree, see also LICENSES/dual/Apache-2.0 (below) and
> > statement wrt compatibility from https://www.apache.org/licenses/GPL-compatibility.html:
> >
> > Valid-License-Identifier: Apache-2.0
> > SPDX-URL: https://spdx.org/licenses/Apache-2.0.html
> > Usage-Guide:
> > Do NOT use. The Apache-2.0 is not GPL2 compatible. [...]
You didn't quote the continuation from LICENSES/dual/Apache-2.0
Usage-Guide:
Do NOT use. The Apache-2.0 is not GPL2 compatible. It may only be used
for dual-licensed files where the other license is GPL2 compatible.
If you end up using this it MUST be used together with a GPL2 compatible
license using "OR".
The way I read it, is that you can use it with "OR", like:
SPDX-License-Identifier: GPL-2.0 OR Apache-2.0
> That is correct, don't use Apache-2 code in the kernel please. Even as
> a dual-license, it's a total mess.
Good, I just wanted to understand why.
> Having this be BSD-2 is actually better, as it should be fine to use
> with Apache 2 code, right?
Yes, that is also my understanding. And it better be as this is needed,
as we want libbpf to be used by https://github.com/iovisor/bcc/ which
is Apache-2.0.
> Jesper, do you know of any license that BSD-2 is not compatible with
> that is needed?
No.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2019-08-16 20:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190816054543.2215626-1-andriin@fb.com>
2019-08-16 12:10 ` [PATCH bpf-next] libbpf: relicense bpf_helpers.h and bpf_endian.h Jesper Dangaard Brouer
2019-08-16 15:29 ` Daniel Borkmann
2019-08-16 17:15 ` Greg KH
2019-08-16 20:10 ` Jesper Dangaard Brouer [this message]
2019-08-17 21:30 ` Daniel Borkmann
2019-08-19 17:27 ` Naveen N. Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190816221025.239e9e94@carbon \
--to=brouer@redhat.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=holzheu@linux.vnet.ibm.com \
--cc=john.fastabend@gmail.com \
--cc=kernel-team@fb.com \
--cc=mrostecki@opensuse.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=sargun@sargun.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).