From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68524C3A59B for ; Sat, 17 Aug 2019 19:35:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 397A220880 for ; Sat, 17 Aug 2019 19:35:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726082AbfHQTfJ (ORCPT ); Sat, 17 Aug 2019 15:35:09 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:55476 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725966AbfHQTfJ (ORCPT ); Sat, 17 Aug 2019 15:35:09 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 9EA8314DB6DEB; Sat, 17 Aug 2019 12:35:08 -0700 (PDT) Date: Sat, 17 Aug 2019 12:35:03 -0700 (PDT) Message-Id: <20190817.123503.1634208808108251879.davem@davemloft.net> To: hkallweit1@gmail.com Cc: andrew@lunn.ch, f.fainelli@gmail.com, khilman@baylibre.com, vivien.didelot@gmail.com, netdev@vger.kernel.org, linux-amlogic@lists.infradead.org Subject: Re: [PATCH net-next v3 0/3] net: phy: remove genphy_config_init From: David Miller In-Reply-To: <8790db9d-af10-c3b1-bc65-ee21bb99e6d9@gmail.com> References: <8790db9d-af10-c3b1-bc65-ee21bb99e6d9@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 17 Aug 2019 12:35:08 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Heiner Kallweit Date: Sat, 17 Aug 2019 12:28:18 +0200 > Supported PHY features are either auto-detected or explicitly set. > In both cases calling genphy_config_init isn't needed. All that > genphy_config_init does is removing features that are set as > supported but can't be auto-detected. Basically it duplicates the > code in genphy_read_abilities. Therefore remove genphy_config_init. > > v2: > - remove call also from new adin driver > v3: > - pass NULL as config_init function pointer for dp83848 Series applied.