From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9F27C3A589 for ; Sun, 18 Aug 2019 20:58:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 802442184E for ; Sun, 18 Aug 2019 20:58:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726925AbfHRU6N (ORCPT ); Sun, 18 Aug 2019 16:58:13 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:49094 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726478AbfHRU6N (ORCPT ); Sun, 18 Aug 2019 16:58:13 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D0B3414585EAB; Sun, 18 Aug 2019 13:58:12 -0700 (PDT) Date: Sun, 18 Aug 2019 13:58:08 -0700 (PDT) Message-Id: <20190818.135808.1309228891811712533.davem@davemloft.net> To: tlfalcon@linux.ibm.com Cc: netdev@vger.kernel.org Subject: Re: [PATCH net] ibmvnic: Unmap DMA address of TX descriptor buffers after use From: David Miller In-Reply-To: <1565812625-24364-1-git-send-email-tlfalcon@linux.ibm.com> References: <1565812625-24364-1-git-send-email-tlfalcon@linux.ibm.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 18 Aug 2019 13:58:12 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Thomas Falcon Date: Wed, 14 Aug 2019 14:57:05 -0500 > There's no need to wait until a completion is received to unmap > TX descriptor buffers that have been passed to the hypervisor. > Instead unmap it when the hypervisor call has completed. This patch > avoids the possibility that a buffer will not be unmapped because > a TX completion is lost or mishandled. > > Reported-by: Abdul Haleem > Tested-by: Devesh K. Singh > Signed-off-by: Thomas Falcon Applied.