From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBBC7C3A5A0 for ; Mon, 19 Aug 2019 20:11:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C77A2206C1 for ; Mon, 19 Aug 2019 20:11:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728240AbfHSULJ (ORCPT ); Mon, 19 Aug 2019 16:11:09 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:35730 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727925AbfHSULJ (ORCPT ); Mon, 19 Aug 2019 16:11:09 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 70BC9145F5279; Mon, 19 Aug 2019 13:11:08 -0700 (PDT) Date: Mon, 19 Aug 2019 13:11:07 -0700 (PDT) Message-Id: <20190819.131107.1894082352888011748.davem@davemloft.net> To: vivien.didelot@gmail.com Cc: netdev@vger.kernel.org, marek.behun@nic.cz, f.fainelli@gmail.com, andrew@lunn.ch Subject: Re: [PATCH net-next 0/6] net: dsa: enable and disable all ports From: David Miller In-Reply-To: <20190818173548.19631-1-vivien.didelot@gmail.com> References: <20190818173548.19631-1-vivien.didelot@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 19 Aug 2019 13:11:08 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Vivien Didelot Date: Sun, 18 Aug 2019 13:35:42 -0400 > The DSA stack currently calls the .port_enable and .port_disable switch > callbacks for slave ports only. However, it is useful to call them for all > port types. For example this allows some drivers to delay the optimization > of power consumption after the switch is setup. This can also help reducing > the setup code of drivers a bit. > > The first DSA core patches enable and disable all ports of a switch, regardless > their type. The last mv88e6xxx patches remove redundant code from the driver > setup and the said callbacks, now that they handle SERDES power for all ports. Looks like the bcm_sf2 parts need some adjustments.