From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, jgg@ziepe.ca
Subject: Re: [PATCH V5 0/9] Fixes for vhost metadata acceleration
Date: Mon, 19 Aug 2019 17:08:22 -0400 [thread overview]
Message-ID: <20190819162733-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <663be71f-f96d-cfbc-95a0-da0ac6b82d9f@redhat.com>
On Tue, Aug 13, 2019 at 04:12:49PM +0800, Jason Wang wrote:
>
> On 2019/8/12 下午5:49, Michael S. Tsirkin wrote:
> > On Mon, Aug 12, 2019 at 10:44:51AM +0800, Jason Wang wrote:
> > > On 2019/8/11 上午1:52, Michael S. Tsirkin wrote:
> > > > On Fri, Aug 09, 2019 at 01:48:42AM -0400, Jason Wang wrote:
> > > > > Hi all:
> > > > >
> > > > > This series try to fix several issues introduced by meta data
> > > > > accelreation series. Please review.
> > > > >
> > > > > Changes from V4:
> > > > > - switch to use spinlock synchronize MMU notifier with accessors
> > > > >
> > > > > Changes from V3:
> > > > > - remove the unnecessary patch
> > > > >
> > > > > Changes from V2:
> > > > > - use seqlck helper to synchronize MMU notifier with vhost worker
> > > > >
> > > > > Changes from V1:
> > > > > - try not use RCU to syncrhonize MMU notifier with vhost worker
> > > > > - set dirty pages after no readers
> > > > > - return -EAGAIN only when we find the range is overlapped with
> > > > > metadata
> > > > >
> > > > > Jason Wang (9):
> > > > > vhost: don't set uaddr for invalid address
> > > > > vhost: validate MMU notifier registration
> > > > > vhost: fix vhost map leak
> > > > > vhost: reset invalidate_count in vhost_set_vring_num_addr()
> > > > > vhost: mark dirty pages during map uninit
> > > > > vhost: don't do synchronize_rcu() in vhost_uninit_vq_maps()
> > > > > vhost: do not use RCU to synchronize MMU notifier with worker
> > > > > vhost: correctly set dirty pages in MMU notifiers callback
> > > > > vhost: do not return -EAGAIN for non blocking invalidation too early
> > > > >
> > > > > drivers/vhost/vhost.c | 202 +++++++++++++++++++++++++-----------------
> > > > > drivers/vhost/vhost.h | 6 +-
> > > > > 2 files changed, 122 insertions(+), 86 deletions(-)
> > > > This generally looks more solid.
> > > >
> > > > But this amounts to a significant overhaul of the code.
> > > >
> > > > At this point how about we revert 7f466032dc9e5a61217f22ea34b2df932786bbfc
> > > > for this release, and then re-apply a corrected version
> > > > for the next one?
> > >
> > > If possible, consider we've actually disabled the feature. How about just
> > > queued those patches for next release?
> > >
> > > Thanks
> > Sorry if I was unclear. My idea is that
> > 1. I revert the disabled code
> > 2. You send a patch readding it with all the fixes squashed
> > 3. Maybe optimizations on top right away?
> > 4. We queue *that* for next and see what happens.
> >
> > And the advantage over the patchy approach is that the current patches
> > are hard to review. E.g. it's not reasonable to ask RCU guys to review
> > the whole of vhost for RCU usage but it's much more reasonable to ask
> > about a specific patch.
>
>
> Ok. Then I agree to revert.
>
> Thanks
Great, so please send the following:
- revert
- squashed and fixed patch
--
MST
next prev parent reply other threads:[~2019-08-19 21:08 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 5:48 [PATCH V5 0/9] Fixes for vhost metadata acceleration Jason Wang
2019-08-09 5:48 ` [PATCH V5 1/9] vhost: don't set uaddr for invalid address Jason Wang
2019-08-09 5:48 ` [PATCH V5 2/9] vhost: validate MMU notifier registration Jason Wang
2019-08-09 5:48 ` [PATCH V5 3/9] vhost: fix vhost map leak Jason Wang
2019-08-09 5:48 ` [PATCH V5 4/9] vhost: reset invalidate_count in vhost_set_vring_num_addr() Jason Wang
2019-08-09 5:48 ` [PATCH V5 5/9] vhost: mark dirty pages during map uninit Jason Wang
2019-08-09 5:48 ` [PATCH V5 6/9] vhost: don't do synchronize_rcu() in vhost_uninit_vq_maps() Jason Wang
2019-08-09 5:48 ` [PATCH V5 7/9] vhost: do not use RCU to synchronize MMU notifier with worker Jason Wang
2019-08-09 5:48 ` [PATCH V5 8/9] vhost: correctly set dirty pages in MMU notifiers callback Jason Wang
2019-08-09 5:48 ` [PATCH V5 9/9] vhost: do not return -EAGAIN for non blocking invalidation too early Jason Wang
2019-08-10 17:52 ` [PATCH V5 0/9] Fixes for vhost metadata acceleration Michael S. Tsirkin
2019-08-12 2:44 ` Jason Wang
2019-08-12 4:13 ` David Miller
2019-08-12 9:49 ` Michael S. Tsirkin
2019-08-12 13:02 ` Jason Gunthorpe
2019-08-13 8:31 ` Jason Wang
2019-08-13 11:57 ` Jason Gunthorpe
2019-08-13 16:41 ` Christoph Hellwig
2019-08-15 3:28 ` Jason Wang
2019-08-15 3:26 ` Jason Wang
2019-08-15 19:33 ` Jason Gunthorpe
2019-08-13 8:12 ` Jason Wang
2019-08-19 21:08 ` Michael S. Tsirkin [this message]
2019-08-20 2:29 ` Jason Wang
2019-09-01 18:02 ` Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2019-08-07 7:06 [PATCH V4 0/9] Fixes for metadata accelreation Jason Wang
2019-08-07 7:06 ` [PATCH V4 7/9] vhost: do not use RCU to synchronize MMU notifier with worker Jason Wang
2019-08-07 12:07 ` Jason Gunthorpe
2019-08-07 14:02 ` Jason Wang
2019-08-08 12:54 ` Jason Wang
2019-08-10 19:12 ` [PATCH V5 0/9] Fixes for vhost metadata acceleration Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190819162733-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=jasowang@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).