* [PATCH net-next] net: systemport: use devm_platform_ioremap_resource() to simplify code
@ 2019-08-21 13:46 YueHaibing
2019-08-21 16:59 ` Florian Fainelli
2019-08-21 20:53 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2019-08-21 13:46 UTC (permalink / raw)
To: davem, opendmb, f.fainelli, bcm-kernel-feedback-list
Cc: linux-kernel, netdev, YueHaibing
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/ethernet/broadcom/bcmsysport.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c
index 9483553..cae66ba 100644
--- a/drivers/net/ethernet/broadcom/bcmsysport.c
+++ b/drivers/net/ethernet/broadcom/bcmsysport.c
@@ -2420,12 +2420,10 @@ static int bcm_sysport_probe(struct platform_device *pdev)
struct device_node *dn;
struct net_device *dev;
const void *macaddr;
- struct resource *r;
u32 txq, rxq;
int ret;
dn = pdev->dev.of_node;
- r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
of_id = of_match_node(bcm_sysport_of_match, dn);
if (!of_id || !of_id->data)
return -EINVAL;
@@ -2473,7 +2471,7 @@ static int bcm_sysport_probe(struct platform_device *pdev)
goto err_free_netdev;
}
- priv->base = devm_ioremap_resource(&pdev->dev, r);
+ priv->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(priv->base)) {
ret = PTR_ERR(priv->base);
goto err_free_netdev;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: systemport: use devm_platform_ioremap_resource() to simplify code
2019-08-21 13:46 [PATCH net-next] net: systemport: use devm_platform_ioremap_resource() to simplify code YueHaibing
@ 2019-08-21 16:59 ` Florian Fainelli
2019-08-21 20:53 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2019-08-21 16:59 UTC (permalink / raw)
To: YueHaibing, davem, opendmb, bcm-kernel-feedback-list; +Cc: linux-kernel, netdev
On 8/21/19 6:46 AM, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: systemport: use devm_platform_ioremap_resource() to simplify code
2019-08-21 13:46 [PATCH net-next] net: systemport: use devm_platform_ioremap_resource() to simplify code YueHaibing
2019-08-21 16:59 ` Florian Fainelli
@ 2019-08-21 20:53 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-08-21 20:53 UTC (permalink / raw)
To: yuehaibing
Cc: opendmb, f.fainelli, bcm-kernel-feedback-list, linux-kernel, netdev
From: YueHaibing <yuehaibing@huawei.com>
Date: Wed, 21 Aug 2019 21:46:13 +0800
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-21 20:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-21 13:46 [PATCH net-next] net: systemport: use devm_platform_ioremap_resource() to simplify code YueHaibing
2019-08-21 16:59 ` Florian Fainelli
2019-08-21 20:53 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).