From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FA61C3A59E for ; Thu, 22 Aug 2019 03:27:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4BB1722CF7 for ; Thu, 22 Aug 2019 03:27:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730854AbfHVD0y convert rfc822-to-8bit (ORCPT ); Wed, 21 Aug 2019 23:26:54 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:37638 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727553AbfHVD0x (ORCPT ); Wed, 21 Aug 2019 23:26:53 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 4944A15066219; Wed, 21 Aug 2019 20:26:53 -0700 (PDT) Date: Wed, 21 Aug 2019 20:26:52 -0700 (PDT) Message-Id: <20190821.202652.2085562734350733412.davem@davemloft.net> To: marek.behun@nic.cz Cc: netdev@vger.kernel.org, andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, olteanv@gmail.com Subject: Re: [PATCH net-next 08/10] net: dsa: mv88e6xxx: simplify SERDES code for Topaz and Peridot From: David Miller In-Reply-To: <20190821232724.1544-9-marek.behun@nic.cz> References: <20190821232724.1544-1-marek.behun@nic.cz> <20190821232724.1544-9-marek.behun@nic.cz> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 21 Aug 2019 20:26:53 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Marek Behún Date: Thu, 22 Aug 2019 01:27:22 +0200 > int mv88e6390_serdes_power(struct mv88e6xxx_chip *chip, int port, bool on) > { > int lane; > + u8 cmode = chip->ports[port].cmode; Reverse christmas tree please.