From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B8CAC3A5A2 for ; Fri, 23 Aug 2019 21:45:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 30E7E206DD for ; Fri, 23 Aug 2019 21:45:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389740AbfHWVpS (ORCPT ); Fri, 23 Aug 2019 17:45:18 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:38258 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727260AbfHWVpS (ORCPT ); Fri, 23 Aug 2019 17:45:18 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 5AC741543B41C; Fri, 23 Aug 2019 14:45:17 -0700 (PDT) Date: Fri, 23 Aug 2019 14:45:16 -0700 (PDT) Message-Id: <20190823.144516.1474535743879521178.davem@davemloft.net> To: eranbe@mellanox.com Cc: netdev@vger.kernel.org, saeedm@mellanox.com, haiyangz@microsoft.com Subject: Re: [PATCH net-next] net/mlx5: Fix return code in case of hyperv wrong size read From: David Miller In-Reply-To: <1566563687-29760-1-git-send-email-eranbe@mellanox.com> References: <1566563687-29760-1-git-send-email-eranbe@mellanox.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 23 Aug 2019 14:45:17 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Eran Ben Elisha Date: Fri, 23 Aug 2019 15:34:47 +0300 > Return code value could be non deterministic in case of wrong size read. > With this patch, if such error occurs, set rc to be -EIO. > > In addition, mlx5_hv_config_common() supports reading of > HV_CONFIG_BLOCK_SIZE_MAX bytes only, fix to early return error with > bad input. > > Fixes: 913d14e86657 ("net/mlx5: Add wrappers for HyperV PCIe operations") > Reported-by: Leon Romanovsky > Signed-off-by: Eran Ben Elisha Applied, thank you.