From: David Miller <davem@davemloft.net>
To: sd@queasysnail.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] ipv6: propagate ipv6_add_dev's error returns out of ipv6_find_idev
Date: Fri, 23 Aug 2019 14:53:31 -0700 (PDT) [thread overview]
Message-ID: <20190823.145331.2056583913194843050.davem@davemloft.net> (raw)
In-Reply-To: <5bc330e3f8123eb139113ae93851cc17100c22da.1566566438.git.sd@queasysnail.net>
From: Sabrina Dubroca <sd@queasysnail.net>
Date: Fri, 23 Aug 2019 15:44:36 +0200
> Currently, ipv6_find_idev returns NULL when ipv6_add_dev fails,
> ignoring the specific error value. This results in addrconf_add_dev
> returning ENOBUFS in all cases, which is unfortunate in cases such as:
>
> # ip link add dummyX type dummy
> # ip link set dummyX mtu 1200 up
> # ip addr add 2000::/64 dev dummyX
> RTNETLINK answers: No buffer space available
>
> Commit a317a2f19da7 ("ipv6: fail early when creating netdev named all
> or default") introduced error returns in ipv6_add_dev. Before that,
> that function would simply return NULL for all failures.
>
> Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Looks good, applied, thanks Sabrina.
prev parent reply other threads:[~2019-08-23 21:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 13:44 [PATCH net] ipv6: propagate ipv6_add_dev's error returns out of ipv6_find_idev Sabrina Dubroca
2019-08-23 21:53 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190823.145331.2056583913194843050.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).