netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net] Revert "r8169: remove not needed call to dma_sync_single_for_device"
@ 2019-08-23 17:57 Heiner Kallweit
  2019-08-23 22:12 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Heiner Kallweit @ 2019-08-23 17:57 UTC (permalink / raw)
  To: Realtek linux nic maintainers, David Miller; +Cc: netdev, Aaro Koskinen

This reverts commit f072218cca5b076dd99f3dfa3aaafedfd0023a51.

As reported by Aaro this patch causes network problems on
MIPS Loongson platform. Therefore revert it.

Fixes: f072218cca5b ("r8169: remove not needed call to dma_sync_single_for_device")
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reported-by: Aaro Koskinen <aaro.koskinen@iki.fi>
---
This fix doesn't apply cleanly on net-next, I'll provide a separate one for net-next.
---
 drivers/net/ethernet/realtek/r8169_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index e1dd6ea60..bae0074ab 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -5921,6 +5921,7 @@ static struct sk_buff *rtl8169_try_rx_copy(void *data,
 	skb = napi_alloc_skb(&tp->napi, pkt_size);
 	if (skb)
 		skb_copy_to_linear_data(skb, data, pkt_size);
+	dma_sync_single_for_device(d, addr, pkt_size, DMA_FROM_DEVICE);
 
 	return skb;
 }
-- 
2.23.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net] Revert "r8169: remove not needed call to dma_sync_single_for_device"
  2019-08-23 17:57 [PATCH net] Revert "r8169: remove not needed call to dma_sync_single_for_device" Heiner Kallweit
@ 2019-08-23 22:12 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-08-23 22:12 UTC (permalink / raw)
  To: hkallweit1; +Cc: nic_swsd, netdev, aaro.koskinen

From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Fri, 23 Aug 2019 19:57:49 +0200

> This reverts commit f072218cca5b076dd99f3dfa3aaafedfd0023a51.
> 
> As reported by Aaro this patch causes network problems on
> MIPS Loongson platform. Therefore revert it.
> 
> Fixes: f072218cca5b ("r8169: remove not needed call to dma_sync_single_for_device")
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> Reported-by: Aaro Koskinen <aaro.koskinen@iki.fi>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-08-23 22:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-23 17:57 [PATCH net] Revert "r8169: remove not needed call to dma_sync_single_for_device" Heiner Kallweit
2019-08-23 22:12 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).