From: David Miller <davem@davemloft.net>
To: michael.chan@broadcom.com
Cc: jonathan.lemon@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] bnxt_en: Fix allocation of zero statistics block size regression.
Date: Sat, 24 Aug 2019 16:35:00 -0700 (PDT) [thread overview]
Message-ID: <20190824.163500.1308650294352576667.davem@davemloft.net> (raw)
In-Reply-To: <1566539501-5884-1-git-send-email-michael.chan@broadcom.com>
From: Michael Chan <michael.chan@broadcom.com>
Date: Fri, 23 Aug 2019 01:51:41 -0400
> Recent commit added logic to determine the appropriate statistics block
> size to allocate and the size is stored in bp->hw_ring_stats_size. But
> if the firmware spec is older than 1.6.0, it is 0 and not initialized.
> This causes the allocation to fail with size 0 and bnxt_open() to
> abort. Fix it by always initializing bp->hw_ring_stats_size to the
> legacy default size value.
>
> Fixes: 4e7485066373 ("bnxt_en: Allocate the larger per-ring statistics block for 57500 chips.")
> Reported-by: Jonathan Lemon <jonathan.lemon@gmail.com>
> Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Applied.
prev parent reply other threads:[~2019-08-24 23:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 5:51 [PATCH net-next] bnxt_en: Fix allocation of zero statistics block size regression Michael Chan
2019-08-23 14:24 ` Jonathan Lemon
2019-08-24 23:35 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190824.163500.1308650294352576667.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jonathan.lemon@gmail.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).