From: Andrew Lunn <andrew@lunn.ch>
To: "Marek Behún" <marek.behun@nic.cz>
Cc: netdev@vger.kernel.org, Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
David Ahern <dsahern@gmail.com>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH RFC net-next 3/3] net: dsa: implement ndo_set_netlink for chaning port's CPU port
Date: Sat, 24 Aug 2019 17:47:27 +0200 [thread overview]
Message-ID: <20190824154727.GC8251@lunn.ch> (raw)
In-Reply-To: <20190824024251.4542-4-marek.behun@nic.cz>
On Sat, Aug 24, 2019 at 04:42:50AM +0200, Marek Behún wrote:
> Implement ndo_set_iflink for DSA slave device. In multi-CPU port setup
> this should be used to change to which CPU destination port a given port
> should be connected.
>
> This adds a new operation into the DSA switch operations structure,
> port_change_cpu_port. A driver implementing this function has the
> ability to change CPU destination port of a given port.
>
> Signed-off-by: Marek Behún <marek.behun@nic.cz>
> ---
> include/net/dsa.h | 6 ++++++
> net/dsa/slave.c | 35 +++++++++++++++++++++++++++++++++++
> 2 files changed, 41 insertions(+)
>
> diff --git a/include/net/dsa.h b/include/net/dsa.h
> index 64bd70608f2f..4f3f0032b886 100644
> --- a/include/net/dsa.h
> +++ b/include/net/dsa.h
> @@ -545,6 +545,12 @@ struct dsa_switch_ops {
> */
> netdev_tx_t (*port_deferred_xmit)(struct dsa_switch *ds, int port,
> struct sk_buff *skb);
> +
> + /*
> + * Multi-CPU port support
> + */
> + int (*port_change_cpu_port)(struct dsa_switch *ds, int port,
> + struct dsa_port *new_cpu_dp);
> };
Hi Marek
We need to see an actual implementation of this. We don't add new APIs
without having a user.
Andrew
next prev parent reply other threads:[~2019-08-24 15:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-24 2:42 [PATCH RFC net-next 0/3] Multi-CPU DSA support Marek Behún
2019-08-24 2:42 ` [PATCH RFC net-next 1/3] net: dsa: allow for multiple CPU ports Marek Behún
2019-08-24 15:43 ` Andrew Lunn
2019-08-24 17:41 ` Marek Behun
2019-08-24 2:42 ` [PATCH RFC net-next 2/3] net: add ndo for setting the iflink property Marek Behún
2019-08-24 2:42 ` [PATCH RFC net-next 3/3] net: dsa: implement ndo_set_netlink for chaning port's CPU port Marek Behún
2019-08-24 15:47 ` Andrew Lunn [this message]
2019-08-24 2:42 ` [PATCH RFC iproute2-next] iplink: allow to change iplink value Marek Behún
2019-08-24 15:24 ` [PATCH RFC net-next 0/3] Multi-CPU DSA support Andrew Lunn
2019-08-24 17:45 ` Marek Behun
2019-08-24 17:54 ` Andrew Lunn
2019-08-25 4:19 ` Marek Behun
2019-08-24 15:40 ` Vladimir Oltean
2019-08-24 15:44 ` Vladimir Oltean
2019-08-24 17:55 ` Marek Behun
2019-08-24 15:56 ` Andrew Lunn
2019-08-24 17:58 ` Marek Behun
2019-08-24 20:04 ` Florian Fainelli
2019-08-24 21:01 ` Marek Behun
2019-08-25 4:08 ` Marek Behun
2019-08-25 7:13 ` Marek Behun
2019-08-25 15:00 ` Florian Fainelli
2021-04-10 13:34 Ansuel Smith
2021-04-10 13:34 ` [PATCH RFC net-next 3/3] net: dsa: implement ndo_set_netlink for chaning port's CPU port Ansuel Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190824154727.GC8251@lunn.ch \
--to=andrew@lunn.ch \
--cc=dsahern@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=marek.behun@nic.cz \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).