From: Vivien Didelot <vivien.didelot@gmail.com>
To: "Marek Behún" <marek.behun@nic.cz>
Cc: netdev@vger.kernel.org, "Andrew Lunn" <andrew@lunn.ch>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"Marek Behún" <marek.behun@nic.cz>
Subject: Re: [PATCH net-next v3 4/6] net: dsa: mv88e6xxx: simplify SERDES code for Topaz and Peridot
Date: Sun, 25 Aug 2019 12:02:32 -0400 [thread overview]
Message-ID: <20190825120232.GG6729@t480s.localdomain> (raw)
In-Reply-To: <20190825035915.13112-5-marek.behun@nic.cz>
Hi Marek,
On Sun, 25 Aug 2019 05:59:13 +0200, Marek Behún <marek.behun@nic.cz> wrote:
> +int mv88e6341_serdes_get_lane(struct mv88e6xxx_chip *chip, int port, s8 *lane)
> +{
> + u8 cmode = chip->ports[port].cmode;
> +
> + *lane = -1;
> +
> + if (port != 5)
> + return 0;
Aren't you relying on -ENODEV as well?
> +
> + if (cmode == MV88E6XXX_PORT_STS_CMODE_1000BASE_X ||
> + cmode == MV88E6XXX_PORT_STS_CMODE_SGMII ||
> + cmode == MV88E6XXX_PORT_STS_CMODE_2500BASEX)
> + *lane = MV88E6341_PORT5_LANE;
> +
> + return 0;
> +}
next prev parent reply other threads:[~2019-08-25 16:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-25 3:59 [PATCH net-next v3 0/6] net: dsa: mv88e6xxx: Peridot/Topaz SERDES changes Marek Behún
2019-08-25 3:59 ` [PATCH net-next v3 1/6] net: dsa: mv88e6xxx: support 2500base-x in SGMII IRQ handler Marek Behún
2019-08-25 3:59 ` [PATCH net-next v3 2/6] net: dsa: mv88e6xxx: update code operating on hidden registers Marek Behún
2019-08-25 15:07 ` Vivien Didelot
2019-08-25 3:59 ` [PATCH net-next v3 3/6] net: dsa: mv88e6xxx: create serdes_get_lane chip operation Marek Behún
2019-08-25 15:48 ` Vivien Didelot
2019-08-25 16:12 ` Vivien Didelot
2019-08-26 12:21 ` Marek Behun
2019-08-25 3:59 ` [PATCH net-next v3 4/6] net: dsa: mv88e6xxx: simplify SERDES code for Topaz and Peridot Marek Behún
2019-08-25 16:02 ` Vivien Didelot [this message]
2019-08-25 16:36 ` Marek Behun
2019-08-26 16:08 ` Vivien Didelot
2019-08-25 3:59 ` [PATCH net-next v3 5/6] net: dsa: mv88e6xxx: rename port cmode macro Marek Behún
2019-08-25 3:59 ` [PATCH net-next v3 6/6] net: dsa: mv88e6xxx: fully support SERDES on Topaz family Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190825120232.GG6729@t480s.localdomain \
--to=vivien.didelot@gmail.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=marek.behun@nic.cz \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).