From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFFF1C3A59F for ; Mon, 26 Aug 2019 22:17:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B01F6206BA for ; Mon, 26 Aug 2019 22:17:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ACV/m6mX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726505AbfHZWRY (ORCPT ); Mon, 26 Aug 2019 18:17:24 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:41414 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726250AbfHZWRY (ORCPT ); Mon, 26 Aug 2019 18:17:24 -0400 Received: by mail-qt1-f194.google.com with SMTP id i4so19487700qtj.8 for ; Mon, 26 Aug 2019 15:17:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:from:to:cc:subject:in-reply-to:references :mime-version:content-disposition:content-transfer-encoding; bh=7e/5x0vK2ab0mcVQr0RcCoDsYF5Ld0162CJ6NrwniD8=; b=ACV/m6mXr+ZvuqbrUDis5hnJ/Kh7cyFc/FQ/qki3X6cGDnByoGho2HgngvlhHV1Bg+ ZiZk3MHEn7XFe9YrFAsaKLTIzo/S0h6Nek7tdV29j4YN5wCOFFw0/5Fhjbtur5VZ7j6K 9MJHMwPtDRD71nozsCnTfz46BX4WxbD7JeHD6yPsQp4mL3WvLZGFcMxKhs4DrwqeBZqr ABNFAWmTmuFcYFoJ987Addw2V2UWZX7wa2gUSrbH427ewMiifcoSLfN69ELcx4XPHSQV pke69Vhrii+OoKgruvJLP8uiknOOwcHCF7oYfbjo7/Z/h3/683fULJ7pIWGtAhCoaUIg BaCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:from:to:cc:subject:in-reply-to :references:mime-version:content-disposition :content-transfer-encoding; bh=7e/5x0vK2ab0mcVQr0RcCoDsYF5Ld0162CJ6NrwniD8=; b=JAwzW7oNIcQeueRMtPYZNYCyAm7U1dwh/FafqoMhOUN/WshZv+amOIX1t1RH9ZfC0D pBeYLz+vBCc1Wg0YR5qO/O+OQ3N4Ayv71tdWlb/lt/LF8ZEM5yXqRD5ZMYHdL/XInJzz wPwKlb/YUxV9eIJm+I5GbD0HE1XQu17/qbCN1oJjx+RJkenxteiFw667oofwzrn4EDRt Y8KjikjMJNM71mo6iQOhZb17Xvu6DokDpNaiYtxe0QB0rH8om+8B/e8SWBYgFXVHfJ3i zTFPstl5B4AwtZOY/5vqnSAs+IUzjiXJmmmh9IGrHteCOheek2Jp9s7j5kHKvF/hWLeY u3nQ== X-Gm-Message-State: APjAAAVY65RDiVcLh/MNFEI00cJY1jX5ZyoOg+o36FDhtHNNbKlNh1Js vY66xfaXdFvG2KhPN33nWi/hAml0 X-Google-Smtp-Source: APXvYqyCtx9q/VHdocAoQJyyxWPQHnzEJMBIrGGG3fWxVbPljFAyRQvk91ac0/Fxvut/4oMiQ+d41Q== X-Received: by 2002:ac8:7158:: with SMTP id h24mr19613776qtp.73.1566857843532; Mon, 26 Aug 2019 15:17:23 -0700 (PDT) Received: from localhost (modemcable249.105-163-184.mc.videotron.ca. [184.163.105.249]) by smtp.gmail.com with ESMTPSA id 143sm7059213qkl.114.2019.08.26.15.17.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Aug 2019 15:17:22 -0700 (PDT) Date: Mon, 26 Aug 2019 18:17:22 -0400 Message-ID: <20190826181722.GD27244@t480s.localdomain> From: Vivien Didelot To: Marek =?UTF-8?B?QmVow7pu?= Cc: netdev@vger.kernel.org, Andrew Lunn , Florian Fainelli , Vladimir Oltean , Marek =?UTF-8?B?QmVow7pu?= Subject: Re: [PATCH net-next v5 3/6] net: dsa: mv88e6xxx: create serdes_get_lane chip operation In-Reply-To: <20190826213155.14685-4-marek.behun@nic.cz> References: <20190826213155.14685-1-marek.behun@nic.cz> <20190826213155.14685-4-marek.behun@nic.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Marek, On Mon, 26 Aug 2019 23:31:52 +0200, Marek Behún wrote: > @@ -635,10 +660,10 @@ static irqreturn_t mv88e6390_serdes_thread_fn(int irq, void *dev_id) > irqreturn_t ret = IRQ_NONE; > u8 cmode = port->cmode; > u16 status; > - int lane; > int err; > + u8 lane; > > - lane = mv88e6390x_serdes_get_lane(chip, port->port); > + mv88e6xxx_serdes_get_lane(chip, port->port, &lane); I don't like when errors aren't always checked, but the code was already like this, so this can be addressed in a follow-up patch: Reviewed-by: Vivien Didelot Thanks, Vivien