From: David Miller <davem@davemloft.net>
To: wang.yi59@zte.com.cn
Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
xue.zhihong@zte.com.cn, wang.liang82@zte.com.cn,
cheng.lin130@zte.com.cn
Subject: Re: [PATCH] ipv6: Not to probe neighbourless routes
Date: Tue, 27 Aug 2019 13:49:22 -0700 (PDT) [thread overview]
Message-ID: <20190827.134922.1122516005541933425.davem@davemloft.net> (raw)
In-Reply-To: <1566896907-5121-1-git-send-email-wang.yi59@zte.com.cn>
Nothing says "low quality patch submission" like:
net/ipv6/route.c: In function ‘rt6_probe’:
net/ipv6/route.c:660:10: error: ‘struct fib6_nh’ has no member named ‘last_probe’
fib6_nh->last_probe = jiffies;
"I did not even try to compile this"
next prev parent reply other threads:[~2019-08-27 20:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 9:08 [PATCH] ipv6: Not to probe neighbourless routes Yi Wang
2019-08-27 15:22 ` Eric Dumazet
2019-08-27 20:49 ` David Miller [this message]
2019-08-29 22:20 ` kbuild test robot
2019-08-29 23:37 ` David Miller
2019-08-30 1:00 ` [kbuild-all] " Philip Li
2019-08-29 22:42 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827.134922.1122516005541933425.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cheng.lin130@zte.com.cn \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wang.liang82@zte.com.cn \
--cc=wang.yi59@zte.com.cn \
--cc=xue.zhihong@zte.com.cn \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).