From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DFC9C3A5A3 for ; Tue, 27 Aug 2019 12:55:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2FF0F206BF for ; Tue, 27 Aug 2019 12:55:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="r3xQ/FkO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727380AbfH0MzI (ORCPT ); Tue, 27 Aug 2019 08:55:08 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:34224 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725920AbfH0MzI (ORCPT ); Tue, 27 Aug 2019 08:55:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=QQIZRKtBn4+mCRvrRB7rANCiu7s243FAxJxmiRuz/gE=; b=r3xQ/FkOpOf7TZVM3ElpTJ1S5x dHcBJlwUfU7QrDlwfFKJ6y42kryByRVRx+7k9NnkTeCEt5OGgkXrnDmerB24TXvYC2EaP/jxuu9DV p7OgTUqO0FoqATus5zeDeLUbFkV1yJhCSnpJFV5RMprMZrpnb7MwPOfPkiUEs7aZhlRg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1i2b04-0003AX-Tl; Tue, 27 Aug 2019 14:55:04 +0200 Date: Tue, 27 Aug 2019 14:55:04 +0200 From: Andrew Lunn To: Razvan Stefanescu Cc: Woojung Huh , Microchip Linux Driver Support , Vivien Didelot , Florian Fainelli , "David S . Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] net: dsa: microchip: avoid hard-codded port count Message-ID: <20190827125504.GB11471@lunn.ch> References: <20190827093110.14957-1-razvan.stefanescu@microchip.com> <20190827093110.14957-5-razvan.stefanescu@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190827093110.14957-5-razvan.stefanescu@microchip.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Aug 27, 2019 at 12:31:10PM +0300, Razvan Stefanescu wrote: > Use port_cnt value to disable interrupts on switch reset. > > Signed-off-by: Razvan Stefanescu > --- > drivers/net/dsa/microchip/ksz9477.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c > index 187be42de5f1..54fc05595d48 100644 > --- a/drivers/net/dsa/microchip/ksz9477.c > +++ b/drivers/net/dsa/microchip/ksz9477.c > @@ -213,7 +213,7 @@ static int ksz9477_reset_switch(struct ksz_device *dev) > > /* disable interrupts */ > ksz_write32(dev, REG_SW_INT_MASK__4, SWITCH_INT_MASK); > - ksz_write32(dev, REG_SW_PORT_INT_MASK__4, 0x7F); > + ksz_write32(dev, REG_SW_PORT_INT_MASK__4, dev->port_cnt); > ksz_read32(dev, REG_SW_PORT_INT_STATUS__4, &data32); Humm, is this correct? 0x7f suggests this is a bitmap for 7 ports. The name port_cnt suggests it is a count, e.g. 7 for 7 ports. 0x7f != 7. Thanks Andrew