From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BA00C3A5A3 for ; Tue, 27 Aug 2019 13:53:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5C68020828 for ; Tue, 27 Aug 2019 13:53:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="BwTqcUAP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728415AbfH0NxA (ORCPT ); Tue, 27 Aug 2019 09:53:00 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:34546 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726170AbfH0NxA (ORCPT ); Tue, 27 Aug 2019 09:53:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=RSZNT4ssH1KSyi6q+em3w02tElqkWq3YebMLf+p5fSE=; b=BwTqcUAPFd1rp8JmacvViM+vcG u26p80dgsNJeOr3iDlT4zQYvq3DJDcSoe9D11aYY+WAR8rjpyGojOgnbpsPkjpNZmyuqlRNYuDtdF n1GK/7B+ya/f6TsT8EfyuFOskOBZzil09yn7qba5VmeN5F5XDrVQhTy+vZivtNiyvl8Y=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1i2bu5-0003c3-UH; Tue, 27 Aug 2019 15:52:57 +0200 Date: Tue, 27 Aug 2019 15:52:57 +0200 From: Andrew Lunn To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: Vivien Didelot , netdev@vger.kernel.org, Florian Fainelli , Vladimir Oltean Subject: Re: [PATCH net-next v5 3/6] net: dsa: mv88e6xxx: create serdes_get_lane chip operation Message-ID: <20190827135257.GL2168@lunn.ch> References: <20190826213155.14685-1-marek.behun@nic.cz> <20190826213155.14685-4-marek.behun@nic.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190826213155.14685-4-marek.behun@nic.cz> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Aug 26, 2019 at 11:31:52PM +0200, Marek Behún wrote: > Create a serdes_get_lane() method in the mv88e6xxx operations structure. > Use it instead of calling the different implementations. > Also change the methods so that their return value is used only for > error. The lane number is put into a place referred to by a pointer > given as argument. If the port does not have a lane, return -ENODEV. > Lanes are phy addresses, so use u8 as their type. > > Signed-off-by: Marek Behún Reviewed-by: Andrew Lunn Andrew