netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Colin Ian King <colin.king@canonical.com>,
	netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
	Andrew Bowers <andrewx.bowers@intel.com>,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 09/15] ice: fix potential infinite loop
Date: Tue, 27 Aug 2019 09:38:26 -0700	[thread overview]
Message-ID: <20190827163832.8362-10-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <20190827163832.8362-1-jeffrey.t.kirsher@intel.com>

From: Colin Ian King <colin.king@canonical.com>

The loop counter of a for-loop is a u8 however this is being compared
to an int upper bound and this can lead to an infinite loop if the
upper bound is greater than 255 since the loop counter will wrap back
to zero. Fix this potential issue by making the loop counter an int.

Addresses-Coverity: ("Infinite loop")
Fixes: c7aeb4d1b9bf ("ice: Disable VFs until reset is completed")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/ice/ice_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
index 67cbebe1ff3f..0398c86226f0 100644
--- a/drivers/net/ethernet/intel/ice/ice_main.c
+++ b/drivers/net/ethernet/intel/ice/ice_main.c
@@ -477,7 +477,7 @@ static void
 ice_prepare_for_reset(struct ice_pf *pf)
 {
 	struct ice_hw *hw = &pf->hw;
-	u8 i;
+	int i;
 
 	/* already prepared for reset */
 	if (test_bit(__ICE_PREPARED_FOR_RESET, pf->state))
-- 
2.21.0


  parent reply	other threads:[~2019-08-27 16:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-27 16:38 [net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2019-08-26 Jeff Kirsher
2019-08-27 16:38 ` [net-next 01/15] ice: Fix ethtool port and PFC stats for 4x25G cards Jeff Kirsher
2019-08-27 16:38 ` [net-next 02/15] ice: added sibling head to parse nodes Jeff Kirsher
2019-08-27 16:38 ` [net-next 03/15] ice: Sanitize ice_ena_vsi and ice_dis_vsi Jeff Kirsher
2019-08-27 16:38 ` [net-next 04/15] ice: shorten local and add debug prints Jeff Kirsher
2019-08-27 16:38 ` [net-next 05/15] ice: Introduce a local variable for a VSI in the rebuild path Jeff Kirsher
2019-08-27 16:38 ` [net-next 06/15] ice: Don't clog kernel debug log with VF MDD events errors Jeff Kirsher
2019-08-27 16:38 ` [net-next 07/15] ice: add validation in OP_CONFIG_VSI_QUEUES VF message Jeff Kirsher
2019-08-27 16:38 ` [net-next 08/15] ice: fix ice_is_tc_ena Jeff Kirsher
2019-08-27 16:38 ` Jeff Kirsher [this message]
2019-08-27 16:38 ` [net-next 10/15] ice: add support for enabling/disabling single queues Jeff Kirsher
2019-08-27 16:38 ` [net-next 11/15] ice: add support for virtchnl_queue_select.[tx|rx]_queues bitmap Jeff Kirsher
2019-08-27 16:38 ` [net-next 12/15] ice: Alloc queue management bitmaps and arrays dynamically Jeff Kirsher
2019-08-27 16:38 ` [net-next 13/15] ice: Fix VF configuration issues due to reset Jeff Kirsher
2019-08-27 16:38 ` [net-next 14/15] ice: Rework ice_ena_msix_range Jeff Kirsher
2019-08-27 16:38 ` [net-next 15/15] ice: fix adminq calls during remove Jeff Kirsher
2019-08-28  4:09 ` [net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2019-08-26 Jakub Kicinski
2019-08-28  4:17   ` Jeff Kirsher
2019-08-28 22:47 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190827163832.8362-10-jeffrey.t.kirsher@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=andrewx.bowers@intel.com \
    --cc=colin.king@canonical.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@redhat.com \
    --cc=sassmann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).