From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E22EC3A5A6 for ; Sat, 31 Aug 2019 19:42:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 34AA221874 for ; Sat, 31 Aug 2019 19:42:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="QwGuLaNj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728504AbfHaTmT (ORCPT ); Sat, 31 Aug 2019 15:42:19 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:46554 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726705AbfHaTmS (ORCPT ); Sat, 31 Aug 2019 15:42:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=v2ggbygz3WEVv5vP4LbXnaNagw4Q4md4pcMHXR0s6P4=; b=QwGuLaNjviGrxuFUXH+1bNJ6i6 tCEx6hKIrKIy0WyBKmzphOrx1hPRkxY/3QvC0RZlIO3ggoLRvG7k1Z84733fAWl1v4Kt9bzQWPrD0 lRGO4/8yjfc0jPiGb7Ry8DA3jDDP6IXvx82ZUKGgVXBBIOKQU+ll/uq31KKpXaS5siYk=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1i49G0-0001CY-V1; Sat, 31 Aug 2019 21:41:56 +0200 Date: Sat, 31 Aug 2019 21:41:56 +0200 From: Andrew Lunn To: Jakub Kicinski Cc: Vladimir Oltean , Florian Fainelli , Vivien Didelot , "David S. Miller" , Vinicius Costa Gomes , vedang.patel@intel.com, Richard Cochran , weifeng.voon@intel.com, jiri@mellanox.com, m-karicheri2@ti.com, Jose.Abreu@synopsys.com, Ilias Apalodimas , Jamal Hadi Salim , xiyou.wangcong@gmail.com, netdev Subject: Re: [RFC PATCH v2 net-next 00/15] tc-taprio offload for SJA1105 DSA Message-ID: <20190831194156.GC2647@lunn.ch> References: <20190830004635.24863-1-olteanv@gmail.com> <20190829182132.43001706@cakuba.netronome.com> <20190830152839.0fe34d25@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190830152839.0fe34d25@cakuba.netronome.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > I'm not 100% sure how taprio handles locking TBH, it just seems naive > that HW callback will not need to sleep, so the kernel should make sure > that callback can sleep. Otherwise we'll end up with 3/4 of drivers > implementing some async work routine... Hi Jakub I suspect this is because until recently, all such devices were on a PCI bus, for some other form of memory mapped device. It is only recently with DSA becoming popular, that we need to handle devices on the end of other sorts of bus, be is MDIO, SPI or i2c. Andrew