From: David Miller <davem@davemloft.net>
To: benwei@fb.com
Cc: sam@mendozajonas.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org
Subject: Re: [PATCH net-next] net/ncsi: support unaligned payload size in NC-SI cmd handler
Date: Mon, 02 Sep 2019 12:03:00 -0700 (PDT) [thread overview]
Message-ID: <20190902.120300.174900457187536042.davem@davemloft.net> (raw)
In-Reply-To: <CH2PR15MB368619179F403EAE47FD61F7A3BE0@CH2PR15MB3686.namprd15.prod.outlook.com>
From: Ben Wei <benwei@fb.com>
Date: Mon, 2 Sep 2019 02:46:52 +0000
> Update NC-SI command handler (both standard and OEM) to take into
> account of payload paddings in allocating skb (in case of payload
> size is not 32-bit aligned).
>
> The checksum field follows payload field, without taking payload
> padding into account can cause checksum being truncated, leading to
> dropped packets.
>
> Signed-off-by: Ben Wei <benwei@fb.com>
If you have to align and add padding, I do not see where you are
clearing out that padding memory to make sure it is initialized.
You do comparisons with 'payload' but make adjustments to 'len'.
The logic is very confusing.
next prev parent reply other threads:[~2019-09-02 19:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 2:46 [PATCH net-next] net/ncsi: support unaligned payload size in NC-SI cmd handler Ben Wei
2019-09-02 19:03 ` David Miller [this message]
2019-09-02 23:43 ` Ben Wei
2019-09-03 19:21 ` Justin.Lee1
2019-09-12 19:45 ` Ben Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190902.120300.174900457187536042.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benwei@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=sam@mendozajonas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).