netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Parav Pandit <parav@mellanox.com>
To: alex.williamson@redhat.com, jiri@mellanox.com,
	kwankhede@nvidia.com, cohuck@redhat.com, davem@davemloft.net
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, Parav Pandit <parav@mellanox.com>
Subject: [PATCH v3 3/5] mdev: Expose mdev alias in sysfs tree
Date: Sun,  1 Sep 2019 23:24:34 -0500	[thread overview]
Message-ID: <20190902042436.23294-4-parav@mellanox.com> (raw)
In-Reply-To: <20190902042436.23294-1-parav@mellanox.com>

Expose the optional alias for an mdev device as a sysfs attribute.
This way, userspace tools such as udev may make use of the alias, for
example to create a netdevice name for the mdev.

Updated documentation for optional read only sysfs attribute.

Signed-off-by: Parav Pandit <parav@mellanox.com>

---
Changelog:
v2->v3:
 - Merged sysfs documentation patch with sysfs addition
 - Added more description for alias return value
v0->v1:
 - Addressed comments from Cornelia Huck
 - Updated commit description
---
 Documentation/driver-api/vfio-mediated-device.rst |  9 +++++++++
 drivers/vfio/mdev/mdev_sysfs.c                    | 13 +++++++++++++
 2 files changed, 22 insertions(+)

diff --git a/Documentation/driver-api/vfio-mediated-device.rst b/Documentation/driver-api/vfio-mediated-device.rst
index 25eb7d5b834b..0b7d2bf843b6 100644
--- a/Documentation/driver-api/vfio-mediated-device.rst
+++ b/Documentation/driver-api/vfio-mediated-device.rst
@@ -270,6 +270,7 @@ Directories and Files Under the sysfs for Each mdev Device
          |--- remove
          |--- mdev_type {link to its type}
          |--- vendor-specific-attributes [optional]
+         |--- alias
 
 * remove (write only)
 
@@ -281,6 +282,14 @@ Example::
 
 	# echo 1 > /sys/bus/mdev/devices/$mdev_UUID/remove
 
+* alias (read only, optional)
+Whenever a parent requested to generate an alias, each mdev device of such
+parent is assigned unique alias by the mdev core.
+This file shows the alias of the mdev device.
+
+Reading file either returns valid alias when assigned or returns error code
+-EOPNOTSUPP when unsupported.
+
 Mediated device Hot plug
 ------------------------
 
diff --git a/drivers/vfio/mdev/mdev_sysfs.c b/drivers/vfio/mdev/mdev_sysfs.c
index 43afe0e80b76..59f4e3cc5233 100644
--- a/drivers/vfio/mdev/mdev_sysfs.c
+++ b/drivers/vfio/mdev/mdev_sysfs.c
@@ -246,7 +246,20 @@ static ssize_t remove_store(struct device *dev, struct device_attribute *attr,
 
 static DEVICE_ATTR_WO(remove);
 
+static ssize_t alias_show(struct device *device,
+			  struct device_attribute *attr, char *buf)
+{
+	struct mdev_device *dev = mdev_from_dev(device);
+
+	if (!dev->alias)
+		return -EOPNOTSUPP;
+
+	return sprintf(buf, "%s\n", dev->alias);
+}
+static DEVICE_ATTR_RO(alias);
+
 static const struct attribute *mdev_device_attrs[] = {
+	&dev_attr_alias.attr,
 	&dev_attr_remove.attr,
 	NULL,
 };
-- 
2.19.2


  parent reply	other threads:[~2019-09-02  4:24 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-26 20:41 [PATCH 0/4] Introduce variable length mdev alias Parav Pandit
2019-08-26 20:41 ` [PATCH 1/4] mdev: Introduce sha1 based " Parav Pandit
2019-08-27  1:44   ` Alex Williamson
2019-08-27  1:51     ` Alex Williamson
2019-08-27  4:24     ` Parav Pandit
2019-08-27 10:24   ` Cornelia Huck
2019-08-27 11:12     ` Parav Pandit
2019-08-27 11:24       ` Cornelia Huck
2019-08-27 11:33         ` Parav Pandit
2019-08-27 11:41           ` Cornelia Huck
2019-08-27 11:57             ` Parav Pandit
2019-08-27 13:35               ` Cornelia Huck
2019-08-27 16:50                 ` Alex Williamson
2019-08-27 11:16     ` Parav Pandit
2019-08-26 20:41 ` [PATCH 2/4] mdev: Make mdev alias unique among all mdevs Parav Pandit
2019-08-26 23:02   ` Mark Bloch
2019-08-27  4:28     ` Parav Pandit
2019-08-27 15:23       ` Alex Williamson
2019-08-27 16:16         ` Parav Pandit
2019-08-27 10:29   ` Cornelia Huck
2019-08-27 11:08     ` Parav Pandit
2019-08-27 11:29       ` Cornelia Huck
2019-08-27 15:28         ` Alex Williamson
2019-08-27 15:39           ` Cornelia Huck
2019-08-27 16:13           ` Parav Pandit
2019-08-27 16:24             ` Alex Williamson
2019-08-27 18:54               ` Parav Pandit
2019-08-26 20:41 ` [PATCH 3/4] mdev: Expose mdev alias in sysfs tree Parav Pandit
2019-08-27  1:53   ` Alex Williamson
2019-08-27  3:30     ` Parav Pandit
2019-08-27 10:47   ` Cornelia Huck
2019-08-27 11:07     ` Parav Pandit
2019-08-27 11:34       ` Cornelia Huck
2019-08-27 11:52         ` Parav Pandit
2019-08-27 11:55           ` Cornelia Huck
2019-08-27 12:00             ` Parav Pandit
2019-08-26 20:41 ` [PATCH 4/4] mtty: Optionally support mtty alias Parav Pandit
2019-08-27 13:11 ` [PATCH 0/4] Introduce variable length mdev alias Parav Pandit
2019-08-27 13:31   ` Cornelia Huck
2019-08-27 17:48   ` Alex Williamson
2019-08-27 18:11     ` Parav Pandit
2019-08-27 19:16 ` [PATCH v1 0/5] " Parav Pandit
2019-08-27 19:16   ` [PATCH v1 1/5] mdev: Introduce sha1 based " Parav Pandit
2019-08-28 21:25     ` Alex Williamson
2019-08-28 21:34       ` Alex Williamson
2019-08-29  9:07         ` Parav Pandit
2019-08-29  9:06       ` Parav Pandit
2019-08-27 19:16   ` [PATCH v1 2/5] mdev: Make mdev alias unique among all mdevs Parav Pandit
2019-08-28 21:36     ` Alex Williamson
2019-08-29  9:07       ` Parav Pandit
2019-08-27 19:16   ` [PATCH v1 3/5] mdev: Expose mdev alias in sysfs tree Parav Pandit
2019-08-27 19:16   ` [PATCH v1 4/5] mdev: Update sysfs documentation Parav Pandit
2019-08-27 19:16   ` [PATCH v1 5/5] mtty: Optionally support mtty alias Parav Pandit
2019-08-29 11:18 ` [PATCH v2 0/6] Introduce variable length mdev alias Parav Pandit
2019-08-29 11:18   ` [PATCH v2 1/6] mdev: Introduce sha1 based " Parav Pandit
2019-08-29 12:26     ` Yunsheng Lin
2019-08-30  2:27       ` Parav Pandit
2019-08-30  9:17     ` Cornelia Huck
2019-08-30 12:33       ` Parav Pandit
2019-08-30 12:39         ` Cornelia Huck
2019-08-30 12:58           ` Parav Pandit
2019-08-30 14:02             ` Cornelia Huck
2019-08-30 15:45               ` Parav Pandit
2019-09-02 14:46                 ` Cornelia Huck
2019-09-03  3:47                   ` Parav Pandit
2019-08-29 11:19   ` [PATCH v2 2/6] mdev: Make mdev alias unique among all mdevs Parav Pandit
2019-08-29 12:31     ` Yunsheng Lin
2019-08-30 12:40     ` Cornelia Huck
2019-08-30 12:59       ` Parav Pandit
2019-08-29 11:19   ` [PATCH v2 3/6] mdev: Expose mdev alias in sysfs tree Parav Pandit
2019-08-29 11:19   ` [PATCH v2 4/6] mdev: Introduce an API mdev_alias Parav Pandit
2019-08-29 11:19   ` [PATCH v2 5/6] mdev: Update sysfs documentation Parav Pandit
2019-08-30 12:49     ` Cornelia Huck
2019-08-30 13:10       ` Parav Pandit
2019-09-02 14:36         ` Cornelia Huck
2019-09-03  3:53           ` Parav Pandit
2019-08-29 11:19   ` [PATCH v2 6/6] mtty: Optionally support mtty alias Parav Pandit
2019-09-02  4:24 ` [PATCH v3 0/5] Introduce variable length mdev alias Parav Pandit
2019-09-02  4:24   ` [PATCH v3 1/5] mdev: Introduce sha1 based " Parav Pandit
2019-09-17 10:03     ` Cornelia Huck
2019-09-02  4:24   ` [PATCH v3 2/5] mdev: Make mdev alias unique among all mdevs Parav Pandit
2019-09-17 10:04     ` Cornelia Huck
2019-09-02  4:24   ` Parav Pandit [this message]
2019-09-17 10:08     ` [PATCH v3 3/5] mdev: Expose mdev alias in sysfs tree Cornelia Huck
2019-09-02  4:24   ` [PATCH v3 4/5] mdev: Introduce an API mdev_alias Parav Pandit
2019-09-17 10:10     ` Cornelia Huck
2019-09-02  4:24   ` [PATCH v3 5/5] mtty: Optionally support mtty alias Parav Pandit
2019-09-09 20:42   ` [PATCH v3 0/5] Introduce variable length mdev alias Parav Pandit
2019-09-11 13:56     ` Alex Williamson
2019-09-11 15:30       ` Parav Pandit
2019-09-11 16:29         ` Cornelia Huck
2019-09-11 16:38         ` Parav Pandit
2019-09-13 21:32           ` Alex Williamson
2019-09-13 23:19             ` Parav Pandit
2019-09-17 10:13   ` Cornelia Huck
2019-09-18 17:15     ` Parav Pandit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190902042436.23294-4-parav@mellanox.com \
    --to=parav@mellanox.com \
    --cc=alex.williamson@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=davem@davemloft.net \
    --cc=jiri@mellanox.com \
    --cc=kvm@vger.kernel.org \
    --cc=kwankhede@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).