From: Greg KH <greg@kroah.com>
To: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Cc: Baolin Wang <baolin.wang@linaro.org>,
stable@vger.kernel.org, vyasevich@gmail.com,
nhorman@tuxdriver.com, davem@davemloft.net,
hariprasad.kelam@gmail.com, linux-sctp@vger.kernel.org,
netdev@vger.kernel.org, arnd@arndb.de, orsonzhai@gmail.com,
vincent.guittot@linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [BACKPORT 4.14.y 4/8] net: sctp: fix warning "NULL check before some freeing functions is not needed"
Date: Tue, 3 Sep 2019 20:33:31 +0200 [thread overview]
Message-ID: <20190903183331.GB26562@kroah.com> (raw)
In-Reply-To: <20190903145206.GB3499@localhost.localdomain>
On Tue, Sep 03, 2019 at 11:52:06AM -0300, Marcelo Ricardo Leitner wrote:
> On Tue, Sep 03, 2019 at 02:58:16PM +0800, Baolin Wang wrote:
> > From: Hariprasad Kelam <hariprasad.kelam@gmail.com>
> >
> > This patch removes NULL checks before calling kfree.
> >
> > fixes below issues reported by coccicheck
> > net/sctp/sm_make_chunk.c:2586:3-8: WARNING: NULL check before some
> > freeing functions is not needed.
> > net/sctp/sm_make_chunk.c:2652:3-8: WARNING: NULL check before some
> > freeing functions is not needed.
> > net/sctp/sm_make_chunk.c:2667:3-8: WARNING: NULL check before some
> > freeing functions is not needed.
> > net/sctp/sm_make_chunk.c:2684:3-8: WARNING: NULL check before some
> > freeing functions is not needed.
>
> Hi. This doesn't seem the kind of patch that should be backported to
> such old/stable releases. After all, it's just a cleanup.
I agree, this does not seem necessary _unless_ it is needed for a later
real fix.
thanks,
greg k-h
next prev parent reply other threads:[~2019-09-03 18:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 6:53 [BACKPORT 4.14.y 0/8] Candidates from Spreadtrum 4.14 product kernel Baolin Wang
2019-09-03 6:56 ` [BACKPORT 4.14.y 2/8] ip6: fix skb leak in ip6frag_expire_frag_queue() Baolin Wang
2019-09-03 6:58 ` [BACKPORT 4.14.y 4/8] net: sctp: fix warning "NULL check before some freeing functions is not needed" Baolin Wang
2019-09-03 14:52 ` Marcelo Ricardo Leitner
2019-09-03 18:33 ` Greg KH [this message]
2019-09-04 2:38 ` Baolin Wang
2019-09-03 7:00 ` [BACKPORT 4.14.y 7/8] ppp: mppe: Revert "ppp: mppe: Add softdep to arc4" Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190903183331.GB26562@kroah.com \
--to=greg@kroah.com \
--cc=arnd@arndb.de \
--cc=baolin.wang@linaro.org \
--cc=davem@davemloft.net \
--cc=hariprasad.kelam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=orsonzhai@gmail.com \
--cc=stable@vger.kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).