From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: "Mauro S. M. Rodrigues" <maurosr@linux.vnet.ibm.com>,
netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
Andrew Bowers <andrewx.bowers@intel.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next v2 12/15] i40e: Remove EMPR traces from debugfs facility
Date: Mon, 9 Sep 2019 15:47:59 -0700 [thread overview]
Message-ID: <20190909224802.29595-13-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <20190909224802.29595-1-jeffrey.t.kirsher@intel.com>
From: "Mauro S. M. Rodrigues" <maurosr@linux.vnet.ibm.com>
Since commit
'5098850c9b9b ("i40e/i40evf: i40e_register.h updates")'
it is no longer possible to trigger an EMP Reset from debugfs, but it's
possible to request it either way, to end up with a bad reset request:
echo empr > /sys/kernel/debug/i40e/0002\:01\:00.1/command
i40e 0002:01:00.1: debugfs: forcing EMPR
i40e 0002:01:00.1: bad reset request 0x00010000
So let's remove this piece of code and show the available valid commands
as it is when any invalid command is issued.
Signed-off-by: "Mauro S. M. Rodrigues" <maurosr@linux.vnet.ibm.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/i40e/i40e.h | 1 -
drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 4 ----
2 files changed, 5 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e.h b/drivers/net/ethernet/intel/i40e/i40e.h
index 3e535d3263b3..f1a1bd324b50 100644
--- a/drivers/net/ethernet/intel/i40e/i40e.h
+++ b/drivers/net/ethernet/intel/i40e/i40e.h
@@ -131,7 +131,6 @@ enum i40e_state_t {
__I40E_PF_RESET_REQUESTED,
__I40E_CORE_RESET_REQUESTED,
__I40E_GLOBAL_RESET_REQUESTED,
- __I40E_EMP_RESET_REQUESTED,
__I40E_EMP_RESET_INTR_RECEIVED,
__I40E_SUSPENDED,
__I40E_PTP_TX_IN_PROGRESS,
diff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
index 41232898d8ae..99ea543dd245 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
@@ -1125,10 +1125,6 @@ static ssize_t i40e_dbg_command_write(struct file *filp,
dev_info(&pf->pdev->dev, "debugfs: forcing GlobR\n");
i40e_do_reset_safe(pf, BIT(__I40E_GLOBAL_RESET_REQUESTED));
- } else if (strncmp(cmd_buf, "empr", 4) == 0) {
- dev_info(&pf->pdev->dev, "debugfs: forcing EMPR\n");
- i40e_do_reset_safe(pf, BIT(__I40E_EMP_RESET_REQUESTED));
-
} else if (strncmp(cmd_buf, "read", 4) == 0) {
u32 address;
u32 value;
--
2.21.0
next prev parent reply other threads:[~2019-09-09 22:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 22:47 [net-next v2 00/15][pull request] Intel Wired LAN Driver Updates 2019-09-09 Jeff Kirsher
2019-09-09 22:47 ` [net-next v2 01/15] iavf: remove unused debug function iavf_debug_d Jeff Kirsher
2019-09-09 22:47 ` [net-next v2 02/15] ixgbevf: Link lost in VM on ixgbevf when restoring from freeze or suspend Jeff Kirsher
2019-09-09 22:47 ` [net-next v2 03/15] e1000e: Make speed detection on hotplugging cable more reliable Jeff Kirsher
2019-09-09 22:47 ` [net-next v2 04/15] igc: Remove useless forward declaration Jeff Kirsher
2019-09-09 22:47 ` [net-next v2 05/15] Documentation: iavf: Update the Intel LAN driver doc for iavf Jeff Kirsher
2019-09-09 22:47 ` [net-next v2 06/15] fm10k: use a local variable for the frag pointer Jeff Kirsher
2019-09-09 22:47 ` [net-next v2 07/15] igc: Add NVM checksum validation Jeff Kirsher
2019-09-09 22:47 ` [net-next v2 08/15] iavf: allow permanent MAC address to change Jeff Kirsher
2019-09-09 22:47 ` [net-next v2 09/15] igc: Remove unneeded PCI bus defines Jeff Kirsher
2019-09-09 22:47 ` [net-next v2 10/15] i40e: fix hw_dbg usage in i40e_hmc_get_object_va Jeff Kirsher
2019-09-09 22:47 ` [net-next v2 11/15] i40e: Implement debug macro hw_dbg using dev_dbg Jeff Kirsher
2019-09-09 22:47 ` Jeff Kirsher [this message]
2019-09-09 22:48 ` [net-next v2 13/15] ixgbe: sync the first fragment unconditionally Jeff Kirsher
2019-09-09 22:48 ` [net-next v2 14/15] igc: Add tx_csum offload functionality Jeff Kirsher
2019-09-09 22:48 ` [net-next v2 15/15] i40e: Add support for X710 device Jeff Kirsher
2019-09-10 7:45 ` [net-next v2 00/15][pull request] Intel Wired LAN Driver Updates 2019-09-09 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190909224802.29595-13-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=andrewx.bowers@intel.com \
--cc=davem@davemloft.net \
--cc=maurosr@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).