From: David Miller <davem@davemloft.net>
To: poeschel@lemonage.de
Cc: allison@lohutok.net, keescook@chromium.org,
opensource@jilayne.com, swinslow@gmail.com,
gregkh@linuxfoundation.org, gustavo@embeddedor.com,
tglx@linutronix.de, kstewart@linuxfoundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
johan@kernel.org
Subject: Re: [PATCH v7 6/7] nfc: pn533: Add autopoll capability
Date: Wed, 11 Sep 2019 10:17:59 +0200 (CEST) [thread overview]
Message-ID: <20190911.101759.1557703938346599792.davem@davemloft.net> (raw)
In-Reply-To: <20190910093415.2186-1-poeschel@lemonage.de>
From: Lars Poeschel <poeschel@lemonage.de>
Date: Tue, 10 Sep 2019 11:34:12 +0200
> +static int pn533_autopoll_complete(struct pn533 *dev, void *arg,
> + struct sk_buff *resp)
> +{
> + u8 nbtg;
> + int rc;
> + struct pn532_autopoll_resp *apr;
> + struct nfc_target nfc_tgt;
Need reverse christmas tree here.
> @@ -1534,6 +1655,7 @@ static int pn533_start_poll(struct nfc_dev *nfc_dev,
> struct pn533_poll_modulations *cur_mod;
> u8 rand_mod;
> int rc;
> + struct sk_buff *skb;
Likewise.
next prev parent reply other threads:[~2019-09-11 8:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 9:34 [PATCH v7 6/7] nfc: pn533: Add autopoll capability Lars Poeschel
2019-09-11 8:17 ` David Miller [this message]
2019-09-17 10:55 ` Lars Poeschel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190911.101759.1557703938346599792.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=allison@lohutok.net \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@embeddedor.com \
--cc=johan@kernel.org \
--cc=keescook@chromium.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opensource@jilayne.com \
--cc=poeschel@lemonage.de \
--cc=swinslow@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).