Netdev Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH iproute2-next] devlink: unknown 'fw_load_policy' string validation
@ 2019-09-11 14:56 Simon Horman
  2019-09-15 17:52 ` David Ahern
  0 siblings, 1 reply; 2+ messages in thread
From: Simon Horman @ 2019-09-11 14:56 UTC (permalink / raw)
  To: David Ahern
  Cc: Jiri Pirko, netdev, oss-drivers, Jakub Kicinski,
	Dirk van der Merwe, Simon Horman

From: Dirk van der Merwe <dirk.vandermerwe@netronome.com>

The 'fw_load_policy' devlink parameter now supports an unknown value.

Suggested-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Dirk van der Merwe <dirk.vandermerwe@netronome.com>
Signed-off-by: Simon Horman <simon.horman@netronome.com>
---

Sorry about these depenendencies, some related changes came through
in separate patch-sets.

1. Depends on iproute2-next patch sent earlier today:
   [PATCH iproute2-next] devlink: add 'reset_dev_on_drv_probe' devlink param

2. Depends on devlink.h changes present in net-next commit:
   64f658ded48e ("devlink: add unknown 'fw_load_policy' value")

   Which in turn depends on other devlink.h changes present in net-next commit:
   5bbd21df5a07 ("devlink: add 'reset_dev_on_drv_probe' param")
---
 devlink/devlink.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/devlink/devlink.c b/devlink/devlink.c
index 15877a04f5d6..e4b494eb3e5d 100644
--- a/devlink/devlink.c
+++ b/devlink/devlink.c
@@ -2259,6 +2259,11 @@ static const struct param_val_conv param_val_conv[] = {
 		.vuint = DEVLINK_PARAM_RESET_DEV_ON_DRV_PROBE_VALUE_UNKNOWN,
 	},
 	{
+		.name = "fw_load_policy",
+		.vstr = "unknown",
+		.vuint = DEVLINK_PARAM_FW_LOAD_POLICY_VALUE_UNKNOWN,
+	},
+	{
 		.name = "reset_dev_on_drv_probe",
 		.vstr = "always",
 		.vuint = DEVLINK_PARAM_RESET_DEV_ON_DRV_PROBE_VALUE_ALWAYS,
-- 
2.11.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH iproute2-next] devlink: unknown 'fw_load_policy' string validation
  2019-09-11 14:56 [PATCH iproute2-next] devlink: unknown 'fw_load_policy' string validation Simon Horman
@ 2019-09-15 17:52 ` David Ahern
  0 siblings, 0 replies; 2+ messages in thread
From: David Ahern @ 2019-09-15 17:52 UTC (permalink / raw)
  To: Simon Horman, David Ahern
  Cc: Jiri Pirko, netdev, oss-drivers, Jakub Kicinski, Dirk van der Merwe

On 9/11/19 8:56 AM, Simon Horman wrote:
> From: Dirk van der Merwe <dirk.vandermerwe@netronome.com>
> 
> The 'fw_load_policy' devlink parameter now supports an unknown value.
> 
> Suggested-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> Signed-off-by: Dirk van der Merwe <dirk.vandermerwe@netronome.com>
> Signed-off-by: Simon Horman <simon.horman@netronome.com>
> ---
> 


applied to iproute2-next. Thanks


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-11 14:56 [PATCH iproute2-next] devlink: unknown 'fw_load_policy' string validation Simon Horman
2019-09-15 17:52 ` David Ahern

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org netdev@archiver.kernel.org
	public-inbox-index netdev


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox