From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB40FC49ED9 for ; Thu, 12 Sep 2019 09:38:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C7A4C20856 for ; Thu, 12 Sep 2019 09:38:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730618AbfILJiP (ORCPT ); Thu, 12 Sep 2019 05:38:15 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:54984 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730237AbfILJiP (ORCPT ); Thu, 12 Sep 2019 05:38:15 -0400 Received: from localhost (unknown [148.69.85.38]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 90A2B11F5E99E; Thu, 12 Sep 2019 02:38:11 -0700 (PDT) Date: Thu, 12 Sep 2019 11:38:07 +0200 (CEST) Message-Id: <20190912.113807.52193745382103083.davem@davemloft.net> To: ap420073@gmail.com Cc: netdev@vger.kernel.org, j.vosburgh@gmail.com, vfalico@gmail.com, andy@greyhouse.net, jiri@resnulli.us, sd@queasysnail.net, roopa@cumulusnetworks.com, saeedm@mellanox.com, manishc@marvell.com, rahulv@marvell.com, kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, sashal@kernel.org, hare@suse.de, varun@chelsio.com, ubraun@linux.ibm.com, kgraul@linux.ibm.com, jay.vosburgh@canonical.com Subject: Re: [PATCH net v2 01/11] net: core: limit nested device depth From: David Miller In-Reply-To: References: <20190907134532.31975-1-ap420073@gmail.com> <20190912.003209.917226424625610557.davem@davemloft.net> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 12 Sep 2019 02:38:14 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Taehee Yoo Date: Thu, 12 Sep 2019 12:56:19 +0900 > I tested with this reproducer commands without lockdep. > > ip link add dummy0 type dummy > ip link add link dummy0 name vlan1 type vlan id 1 > ip link set vlan1 up > > for i in {2..200} > do > let A=$i-1 > > ip link add name vlan$i link vlan$A type vlan id $i > done > ip link del vlan1 <-- this command is added. Is there any other device type which allows arbitrary nesting depth in this manner other than VLAN? Perhaps it is the VLAN nesting depth that we should limit instead of all of this extra code.