From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51997C49ED7 for ; Fri, 13 Sep 2019 12:04:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2EB9A2084F for ; Fri, 13 Sep 2019 12:04:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388153AbfIMMEM (ORCPT ); Fri, 13 Sep 2019 08:04:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49150 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387584AbfIMMEM (ORCPT ); Fri, 13 Sep 2019 08:04:12 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E73A418C4299; Fri, 13 Sep 2019 12:04:11 +0000 (UTC) Received: from carbon (ovpn-200-36.brq.redhat.com [10.40.200.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id D2F15608C2; Fri, 13 Sep 2019 12:04:07 +0000 (UTC) Date: Fri, 13 Sep 2019 14:04:06 +0200 From: Jesper Dangaard Brouer To: "Daniel T. Lee" Cc: "David S . Miller" , netdev@vger.kernel.org, brouer@redhat.com Subject: Re: [v2 1/3] samples: pktgen: make variable consistent with option Message-ID: <20190913140406.61e88cad@carbon> In-Reply-To: <20190911184807.21770-1-danieltimlee@gmail.com> References: <20190911184807.21770-1-danieltimlee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.62]); Fri, 13 Sep 2019 12:04:12 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 12 Sep 2019 03:48:05 +0900 "Daniel T. Lee" wrote: > This commit changes variable names that can cause confusion. > > For example, variable DST_MIN is quite confusing since the > keyword 'udp_dst_min' and keyword 'dst_min' is used with pg_ctrl. > > On the following commit, 'dst_min' will be used to set destination IP, > and the existing variable name DST_MIN should be changed. > > Variable names are matched to the exact keyword used with pg_ctrl. > > Signed-off-by: Daniel T. Lee Acked-by: Jesper Dangaard Brouer -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer