From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 605F7C4CEC9 for ; Tue, 17 Sep 2019 12:04:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 30ADD214AF for ; Tue, 17 Sep 2019 12:04:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727179AbfIQMEQ (ORCPT ); Tue, 17 Sep 2019 08:04:16 -0400 Received: from a.mx.secunet.com ([62.96.220.36]:35224 "EHLO a.mx.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726932AbfIQMEQ (ORCPT ); Tue, 17 Sep 2019 08:04:16 -0400 Received: from localhost (localhost [127.0.0.1]) by a.mx.secunet.com (Postfix) with ESMTP id 913D2205A6; Tue, 17 Sep 2019 14:04:14 +0200 (CEST) X-Virus-Scanned: by secunet Received: from a.mx.secunet.com ([127.0.0.1]) by localhost (a.mx.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id p4YxxdqhAhOM; Tue, 17 Sep 2019 14:04:14 +0200 (CEST) Received: from mail-essen-01.secunet.de (mail-essen-01.secunet.de [10.53.40.204]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a.mx.secunet.com (Postfix) with ESMTPS id 2EE7620299; Tue, 17 Sep 2019 14:04:14 +0200 (CEST) Received: from gauss2.secunet.de (10.182.7.193) by mail-essen-01.secunet.de (10.53.40.204) with Microsoft SMTP Server id 14.3.439.0; Tue, 17 Sep 2019 14:04:14 +0200 Received: by gauss2.secunet.de (Postfix, from userid 1000) id BF61731803B6; Tue, 17 Sep 2019 14:04:13 +0200 (CEST) Date: Tue, 17 Sep 2019 14:04:13 +0200 From: Steffen Klassert To: Sabrina Dubroca CC: , Herbert Xu Subject: Re: [PATCH ipsec-next v2 6/6] xfrm: add espintcp (RFC 8229) Message-ID: <20190917120413.GF2879@gauss3.secunet.de> References: <20190917112649.GE2879@gauss3.secunet.de> <20190917115743.GA89567@bistromath.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20190917115743.GA89567@bistromath.localdomain> User-Agent: Mutt/1.9.4 (2018-02-28) X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Sep 17, 2019 at 01:57:43PM +0200, Sabrina Dubroca wrote: > 2019-09-17, 13:26:49 +0200, Steffen Klassert wrote: > > On Wed, Sep 11, 2019 at 04:13:07PM +0200, Sabrina Dubroca wrote: > > ... > > > diff --git a/net/xfrm/Kconfig b/net/xfrm/Kconfig > > > index 51bb6018f3bf..e67044527fb7 100644 > > > --- a/net/xfrm/Kconfig > > > +++ b/net/xfrm/Kconfig > > > @@ -73,6 +73,16 @@ config XFRM_IPCOMP > > > select CRYPTO > > > select CRYPTO_DEFLATE > > > > > > +config XFRM_ESPINTCP > > > + bool "ESP in TCP encapsulation (RFC 8229)" > > > + depends on XFRM && INET_ESP > > > + select STREAM_PARSER > > > + select NET_SOCK_MSG > > > + help > > > + Support for RFC 8229 encapsulation of ESP and IKE over TCP sockets. > > > + > > > + If unsure, say N. > > > + > > > > One nitpick: This is IPv4 only, so please move this below the ESP > > section in net/ipv4/Kconfig and use the naming convention there. > > I.e. bool "IP: ESP in TCP encapsulation (RFC 8229)" > > That's temporary, though, the next step will be to make it work for > both IPv4 and IPv6. Do you prefer I move it to net/ipv4/Kconfig for > now, and then back to net/xfrm/Kconfig when I add IPv6 support? We have separate config options for ESP4 and ESP6, so we should also have separate config options for 'ESP in TCP' for IPv4 and IPv6. So this should go to net/ipv4/Kconfig. When you add IPv6 support place it in net/ipv6/Kconfig.