From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38280C4CEC9 for ; Wed, 18 Sep 2019 16:32:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 06974206C2 for ; Wed, 18 Sep 2019 16:32:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="AJnI+Z2E" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731027AbfIRQcl (ORCPT ); Wed, 18 Sep 2019 12:32:41 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:53260 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726359AbfIRQcl (ORCPT ); Wed, 18 Sep 2019 12:32:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=JM2h7z5mh2kb0CtWLRTSGXMX+lpVQABcP7xIjoBOrH0=; b=AJnI+Z2Evqao1gW2eq+R32q6R8 7QL62YCkgAeqDBPgM9agnFDMd6xShli/DdqyH5WE15a3OcaxUoZJ8LYoa9yRMKxNf9nBDYzif/HYP wsZHXORdkDpNUeSCIVV4Q4NevRZ9esb/3LVAOOsn2tq/CHYSTdrMQTypkiRVDzuSlXWc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1iAcsf-0000Pz-8g; Wed, 18 Sep 2019 18:32:37 +0200 Date: Wed, 18 Sep 2019 18:32:36 +0200 From: Andrew Lunn To: Peter Mamonov Cc: Florian Fainelli , Heiner Kallweit , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v3] net/phy: fix DP83865 10 Mbps HDX loopback disable function Message-ID: <20190918163236.GM9591@lunn.ch> References: <20190918162755.24024-1-pmamonov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190918162755.24024-1-pmamonov@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Sep 18, 2019 at 07:27:55PM +0300, Peter Mamonov wrote: > According to the DP83865 datasheet "the 10 Mbps HDX loopback can be > disabled in the expanded memory register 0x1C0.1". The driver erroneously > used bit 0 instead of bit 1. > > Fixes: 4621bf129856 ("phy: Add file missed in previous commit.") > Signed-off-by: Peter Mamonov Reviewed-by: Andrew Lunn Andrew