From: Andrew Lunn <andrew@lunn.ch>
To: Navid Emamdoost <navid.emamdoost@gmail.com>
Cc: emamd001@umn.edu, smccaman@umn.edu, kjlu@umn.edu,
Vladimir Oltean <olteanv@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: dsa: sja1105: prevent leaking memory
Date: Wed, 18 Sep 2019 19:21:06 +0200 [thread overview]
Message-ID: <20190918172106.GN9591@lunn.ch> (raw)
In-Reply-To: <20190918171020.5745-1-navid.emamdoost@gmail.com>
On Wed, Sep 18, 2019 at 12:10:19PM -0500, Navid Emamdoost wrote:
> In sja1105_static_config_upload, in two cases memory is leaked: when
> static_config_buf_prepare_for_upload fails and when sja1105_inhibit_tx
> fails. In both cases config_buf should be released.
>
> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Hi Navid
Please could you provide a Fixes: tag for where this memory leak was
introduced.
> ---
> drivers/net/dsa/sja1105/sja1105_spi.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/dsa/sja1105/sja1105_spi.c b/drivers/net/dsa/sja1105/sja1105_spi.c
> index 84dc603138cf..80e86c714efb 100644
> --- a/drivers/net/dsa/sja1105/sja1105_spi.c
> +++ b/drivers/net/dsa/sja1105/sja1105_spi.c
> @@ -408,8 +408,9 @@ int sja1105_static_config_upload(struct sja1105_private *priv)
>
> rc = static_config_buf_prepare_for_upload(priv, config_buf, buf_len);
> if (rc < 0) {
> - dev_err(dev, "Invalid config, cannot upload\n");
> - return -EINVAL;
> + dev_err(dev, "Invalid config, cannot upload\n");
What changed in this dev_err() call?
Thanks
Andrew
next prev parent reply other threads:[~2019-09-18 17:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 17:10 [PATCH] net: dsa: sja1105: prevent leaking memory Navid Emamdoost
2019-09-18 17:21 ` Andrew Lunn [this message]
2019-09-18 18:04 ` [PATCH v2] " Navid Emamdoost
2019-09-18 20:00 ` Vladimir Oltean
2019-09-18 20:34 ` [PATCH v3] " Navid Emamdoost
2019-09-18 20:40 ` Vladimir Oltean
2019-09-19 8:13 ` David Miller
2019-09-19 8:10 ` [PATCH v2] " David Miller
2019-09-19 8:20 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190918172106.GN9591@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=emamd001@umn.edu \
--cc=f.fainelli@gmail.com \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=navid.emamdoost@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=smccaman@umn.edu \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).