From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DC9FC4CEC4 for ; Thu, 19 Sep 2019 06:11:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 04B5B21924 for ; Thu, 19 Sep 2019 06:11:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="hitoYH0q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387575AbfISGLh (ORCPT ); Thu, 19 Sep 2019 02:11:37 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:43364 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725887AbfISGLg (ORCPT ); Thu, 19 Sep 2019 02:11:36 -0400 Received: by mail-wr1-f66.google.com with SMTP id q17so1671981wrx.10 for ; Wed, 18 Sep 2019 23:11:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+kJRnH/bobkHHD8pbQwbBalV5RlXRs7lsi398MM0g98=; b=hitoYH0qrf7DoRJ7kw5xIyrIwuyKYlJi3HR62Ok2KWtUmi4lbhSrw7TfTdFUjH9G3n 25ECHYJKD/ybkvDAO7PIIxXI/aPTs+14edqpbMNlnppeXQKFLf3kEUYM+PsNmyZXgZm6 MxqTrCuKBJqKKawXRNQFX0dq9j7Iac0bZOV4BF8Y3oI+mZkg0S2IGolU2RWe9HcLFNJ2 /XKjdQxBBSm25hEVP5r2YwBourumDWz9wae4xxYw4Q/7shT+pr6IAWbx0wd413JIIYOQ qKk61FiVPfj26eJw9ZLpmp4avSiZ/C/nwRBeApiETDFOXvm5gIJZRzaaavltkbYXgG/g vpOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+kJRnH/bobkHHD8pbQwbBalV5RlXRs7lsi398MM0g98=; b=YtRuPI9/+jXq4LhtzWcwqHchI9dbdLjO49ypOYWsYbg4LmoFPSxLhj4dK4nZPjcyX+ FFa21p3x/kz12RtefA0ScWsyAHkcFwNoX8fbvT/qktrx9gU6KE7SA5sRnm35eUFSQwMr nwVcXkCoKmz8KLTCJ6lS06DWSo9M06xy9YF/YkN3Ttoe4eMMr5aRjTdwvLBzdJr37fG1 wa2Zh/Nuv+c9CGoHoN4asfOFWlYSL5rnWv5B+6kDG6f0m/2koMskOZ/3dOR/YksQIN7a tBJZaRF6Spez2KiT1n1ocqDM+DKU0x8Ni3zUzX9kPRUGBM1MSZZnYTWJyHzLdnkqIcFI M1LQ== X-Gm-Message-State: APjAAAUbTDNDoFFHjeAWBiSYzCQxNnv4AsSUBm4/UEe/tfVDxfn+tVhh JSSWiKiYL4cDv1AFYWVqd7y1tg== X-Google-Smtp-Source: APXvYqyteUZGKccctX+0pmHumUNlCkzksd2Swwvkb2aXq671ZL0GC7B1FQDuLPvJ69igKEpQRzAiQw== X-Received: by 2002:a5d:4803:: with SMTP id l3mr5750322wrq.301.1568873494305; Wed, 18 Sep 2019 23:11:34 -0700 (PDT) Received: from localhost (jirka.pirko.cz. [84.16.102.26]) by smtp.gmail.com with ESMTPSA id j26sm13832561wrd.2.2019.09.18.23.11.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2019 23:11:33 -0700 (PDT) Date: Thu, 19 Sep 2019 08:11:33 +0200 From: Jiri Pirko To: Sheetal Tigadoli Cc: Jiri Pirko , "David S. Miller" , Ray Jui , Vikram Prakash , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, BCM Kernel Feedback , Vikas Gupta Subject: Re: [PATCH] devlink: add devlink notification for recovery Message-ID: <20190919061133.GB2187@nanopsycho> References: <1568832741-20850-1-git-send-email-sheetal.tigadoli@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1568832741-20850-1-git-send-email-sheetal.tigadoli@broadcom.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Wed, Sep 18, 2019 at 08:52:21PM CEST, sheetal.tigadoli@broadcom.com wrote: >From: Vikas Gupta > >Add a devlink notification for reporter recovery > >Signed-off-by: Vikas Gupta >Signed-off-by: Sheetal Tigadoli >--- > net/core/devlink.c | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > >diff --git a/net/core/devlink.c b/net/core/devlink.c >index e48680e..42909fb 100644 >--- a/net/core/devlink.c >+++ b/net/core/devlink.c >@@ -4730,6 +4730,28 @@ struct devlink_health_reporter * > } > EXPORT_SYMBOL_GPL(devlink_health_reporter_state_update); > >+static void __devlink_recover_notify(struct devlink *devlink, >+ enum devlink_command cmd) >+{ >+ struct sk_buff *msg; >+ int err; >+ >+ WARN_ON(cmd != DEVLINK_CMD_HEALTH_REPORTER_RECOVER); >+ >+ msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL); >+ if (!msg) >+ return; >+ >+ err = devlink_nl_fill(msg, devlink, cmd, 0, 0, 0); >+ if (err) { >+ nlmsg_free(msg); >+ return; >+ } >+ >+ genlmsg_multicast_netns(&devlink_nl_family, devlink_net(devlink), >+ msg, 0, DEVLINK_MCGRP_CONFIG, GFP_KERNEL); >+} >+ > static int > devlink_health_reporter_recover(struct devlink_health_reporter *reporter, > void *priv_ctx) >@@ -4747,6 +4769,9 @@ struct devlink_health_reporter * > reporter->health_state = DEVLINK_HEALTH_REPORTER_STATE_HEALTHY; > reporter->last_recovery_ts = jiffies; > >+ __devlink_recover_notify(reporter->devlink, >+ DEVLINK_CMD_HEALTH_REPORTER_RECOVER); >+ > return 0; > } To follow the rest of the code The notification should be done upon any reported change, using devlink_nl_health_reporter_fill() to prepare the message. Also, this is net-next patch net-next is closed now. >