From: Andrew Lunn <andrew@lunn.ch>
To: Peter Mamonov <pmamonov@gmail.com>
Cc: f.fainelli@gmail.com, hkallweit1@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH RFC] net/phy: fix Marvell PHYs probe failure when HWMON and THERMAL_OF are enabled
Date: Thu, 19 Sep 2019 15:52:43 +0200 [thread overview]
Message-ID: <20190919135243.GB22556@lunn.ch> (raw)
In-Reply-To: <20190919081055.GD9025@chr>
On Thu, Sep 19, 2019 at 11:10:56AM +0300, Peter Mamonov wrote:
> Hi, Andrew,
>
> On Thu, Sep 19, 2019 at 04:50:16AM +0200, Andrew Lunn wrote:
> > On Thu, Sep 19, 2019 at 12:38:37AM +0300, Peter Mamonov wrote:
> > > Hello,
> > >
> > > Some time ago I've discovered that probe functions of certain Marvell PHYs
> > > fail if both HWMON and THERMAL_OF config options are enabled.
> >
> > Hi Peter
> >
> > It probably affects more then Marvell PHYs.
> >
> > > The root
> > > cause of this problem is a lack of an OF node for a PHY's built-in
> > > temperature sensor. However I consider adding this OF node to be a bit
> > > excessive solution. Am I wrong? Below you will find a one line patch which
> > > fixes the problem.
> >
> > Your patch look sensible to me.
> >
> > > I've sent it to the releveant maintainers three weeks
> > > ago without any feedback yet.
> >
> > Could you point me at the relevant mailing list archive?
>
> Here it is: https://marc.info/?l=linux-pm&m=156691695616377&w=2
Hi Peter
O.K. Thanks.
We should not take this patch via netdev, since it is outside of
netdev, even if it does break netdev. So lets polish the patch a bit,
and then repost it to linux-pm and its maintainers.
Please could you add a Fixes: tag. Can you figure out which commit
broke it, or has it always been broken?
Add a stable: tag, indicating it needs to be back ported. For netdev,
you would not do this, but for linux-pm, i guess it is needed.
Change the subject a little. thermal: Fix broken registration if sensor OF node missing.
Add
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
When you post it, please Cc: me, netdev, davem, but make the To: the
three thermal maintainers.
Thanks
Andrew
prev parent reply other threads:[~2019-09-19 13:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 21:38 [PATCH RFC] net/phy: fix Marvell PHYs probe failure when HWMON and THERMAL_OF are enabled Peter Mamonov
2019-09-19 2:50 ` Andrew Lunn
2019-09-19 8:10 ` Peter Mamonov
2019-09-19 13:52 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190919135243.GB22556@lunn.ch \
--to=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pmamonov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).