From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FDF1C3A5A6 for ; Thu, 19 Sep 2019 16:34:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 773CF21924 for ; Thu, 19 Sep 2019 16:34:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="hwQPpg2M" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404380AbfISQeg (ORCPT ); Thu, 19 Sep 2019 12:34:36 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:55842 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387693AbfISQef (ORCPT ); Thu, 19 Sep 2019 12:34:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=zk34/WaepEZ6aVZJpiWjUS8UF7iUIRACXnV7zV0EX8U=; b=hwQPpg2MxAEK2mGXABpo2ESLzO SpXQrfoXC3ABRO1fNZowoBlu28Gf6eyfYSiciZS6nDtdLwjh1wUdRMuxSwHVLlK/AZ27MN96GGHmA 8kttrhaKx2z4ENgRhGdAGKkdzaguSPi9+iX2Y9UmHHrJVKMKtVucLIwKNyg/2Wq5dYIA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1iAzO1-0007gl-It; Thu, 19 Sep 2019 18:34:29 +0200 Date: Thu, 19 Sep 2019 18:34:29 +0200 From: Andrew Lunn To: Jerome Pouiller Cc: "devel@driverdev.osuosl.org" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , David Le Goff Subject: Re: [PATCH 02/20] staging: wfx: add support for I/O access Message-ID: <20190919163429.GB27277@lunn.ch> References: <20190919105153.15285-1-Jerome.Pouiller@silabs.com> <20190919105153.15285-3-Jerome.Pouiller@silabs.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190919105153.15285-3-Jerome.Pouiller@silabs.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Sep 19, 2019 at 10:52:35AM +0000, Jerome Pouiller wrote: > +static int wfx_sdio_copy_from_io(void *priv, unsigned int reg_id, > + void *dst, size_t count) > +{ > + struct wfx_sdio_priv *bus = priv; > + unsigned int sdio_addr = reg_id << 2; > + int ret; > + > + BUG_ON(reg_id > 7); Hi Jerome BUG_ON should only be used when the system is corrupted, and there is no alternative than to stop the machine, so it does not further corrupt itself. Accessing a register which does not exist is not a reason the kill the machine. A WARN() and a return of -EINVAL would be better. Andrew