* [PATCH net] skge: fix checksum byte order
@ 2019-09-20 16:18 Stephen Hemminger
2019-09-24 14:55 ` David Miller
2019-09-24 16:49 ` Florian Fainelli
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Hemminger @ 2019-09-20 16:18 UTC (permalink / raw)
To: davem; +Cc: netdev, Stephen Hemminger
From: Stephen Hemminger <stephen@networkplumber.org>
Running old skge driver on PowerPC causes checksum errors
because hardware reported 1's complement checksum is in little-endian
byte order.
Reported-by: Benoit <benoit.sansoni@gmail.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/ethernet/marvell/skge.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c
index 0a2ec387a482..095f6c71b4fa 100644
--- a/drivers/net/ethernet/marvell/skge.c
+++ b/drivers/net/ethernet/marvell/skge.c
@@ -3108,7 +3108,7 @@ static struct sk_buff *skge_rx_get(struct net_device *dev,
skb_put(skb, len);
if (dev->features & NETIF_F_RXCSUM) {
- skb->csum = csum;
+ skb->csum = le16_to_cpu(csum);
skb->ip_summed = CHECKSUM_COMPLETE;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] skge: fix checksum byte order
2019-09-20 16:18 [PATCH net] skge: fix checksum byte order Stephen Hemminger
@ 2019-09-24 14:55 ` David Miller
2019-09-24 16:49 ` Florian Fainelli
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-09-24 14:55 UTC (permalink / raw)
To: stephen; +Cc: netdev
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Fri, 20 Sep 2019 18:18:26 +0200
> From: Stephen Hemminger <stephen@networkplumber.org>
>
> Running old skge driver on PowerPC causes checksum errors
> because hardware reported 1's complement checksum is in little-endian
> byte order.
>
> Reported-by: Benoit <benoit.sansoni@gmail.com>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] skge: fix checksum byte order
2019-09-20 16:18 [PATCH net] skge: fix checksum byte order Stephen Hemminger
2019-09-24 14:55 ` David Miller
@ 2019-09-24 16:49 ` Florian Fainelli
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2019-09-24 16:49 UTC (permalink / raw)
To: Stephen Hemminger, davem; +Cc: netdev
On 9/20/19 9:18 AM, Stephen Hemminger wrote:
> From: Stephen Hemminger <stephen@networkplumber.org>
>
> Running old skge driver on PowerPC causes checksum errors
> because hardware reported 1's complement checksum is in little-endian
> byte order.
>
> Reported-by: Benoit <benoit.sansoni@gmail.com>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Fixes: 383181ac7e59 ("[PATCH] skge: check length from PHY")
> ---
> drivers/net/ethernet/marvell/skge.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c
> index 0a2ec387a482..095f6c71b4fa 100644
> --- a/drivers/net/ethernet/marvell/skge.c
> +++ b/drivers/net/ethernet/marvell/skge.c
> @@ -3108,7 +3108,7 @@ static struct sk_buff *skge_rx_get(struct net_device *dev,
> skb_put(skb, len);
>
> if (dev->features & NETIF_F_RXCSUM) {
> - skb->csum = csum;
> + skb->csum = le16_to_cpu(csum);
> skb->ip_summed = CHECKSUM_COMPLETE;
> }
>
>
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-24 16:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-20 16:18 [PATCH net] skge: fix checksum byte order Stephen Hemminger
2019-09-24 14:55 ` David Miller
2019-09-24 16:49 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).